Skip to content

fix: Terraform variable validation - #204

Merged
patrickmoore-nc merged 3 commits into
mainfrom
fix/DTOSS-8953-terraform-variable-validation
Jul 1, 2025
Merged

fix: Terraform variable validation#204
patrickmoore-nc merged 3 commits into
mainfrom
fix/DTOSS-8953-terraform-variable-validation

Conversation

@patrickmoore-nc

@patrickmoore-nc patrickmoore-nc commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Description

Fix some errors in a recent change to validate more Terraform input variables.

Testing

Hub non-live now plans ok:
https://dev.azure.com/nhse-dtos/dtos-hub/_build/results?buildId=19958&view=results

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@saliceti

saliceti commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

I've seen another error:

   on ../../dtos-devops-templates/infrastructure/modules/firewall-policy/variables.tf line 5, in variable "policy_name":
│    5:     condition     = can(regex("^[a-zA-Z0-9_][a-zA-Z0-9-_]{0,78}[a-zA-Z0-9_]$", var.name))

@patrickmoore-nc
patrickmoore-nc added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 377c9c4 Jul 1, 2025
13 checks passed
@patrickmoore-nc
patrickmoore-nc deleted the fix/DTOSS-8953-terraform-variable-validation branch July 1, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants