Skip to content

Chore: [AEA-0000] - workflow to update dev container#640

Merged
anthony-nhs merged 1 commit intomainfrom
workflow_to_update_dev_container
Mar 27, 2026
Merged

Chore: [AEA-0000] - workflow to update dev container#640
anthony-nhs merged 1 commit intomainfrom
workflow_to_update_dev_container

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change

Details

  • workflow to update dev container

Copilot AI review requested due to automatic review settings March 27, 2026 12:04
@github-actions
Copy link
Copy Markdown
Contributor

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-0000

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a scheduled/manual GitHub Actions workflow that invokes a reusable workflow from NHSDigital/eps-common-workflows to automatically update the repository devcontainer version.

Changes:

  • Introduces .github/workflows/update_dev_container_version.yml with workflow_dispatch + weekly schedule triggers.
  • Calls the shared update-dev-container-version.yml reusable workflow pinned to a specific commit SHA and passes the base branch + GitHub App secrets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to +19
workflow_dispatch:
schedule:
- cron: "0 18 * * 4"

jobs:
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6
permissions:
contents: read
packages: read
pull-requests: write
with:
base_branch: main
secrets:
CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation in this workflow uses 4+ spaces under on:/jobs: (e.g., workflow_dispatch, schedule, and the job definition). The rest of the workflows in this repo consistently use 2-space indentation, so aligning this file to that convention would improve readability and reduce diff noise in future edits.

Suggested change
workflow_dispatch:
schedule:
- cron: "0 18 * * 4"
jobs:
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6
permissions:
contents: read
packages: read
pull-requests: write
with:
base_branch: main
secrets:
CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}
workflow_dispatch:
schedule:
- cron: "0 18 * * 4"
jobs:
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6
permissions:
contents: read
packages: read
pull-requests: write
with:
base_branch: main
secrets:
CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}

Copilot uses AI. Check for mistakes.
workflow_dispatch:
schedule:
- cron: "0 18 * * 4"

Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this workflow can be triggered both on a schedule and manually (workflow_dispatch), two runs can overlap and potentially open duplicate/competing PRs. Consider adding a concurrency group (and optionally cancel-in-progress: true) to ensure only one update run executes at a time.

Suggested change
concurrency:
group: update-devcontainer-version
cancel-in-progress: true

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link
Copy Markdown

@anthony-nhs anthony-nhs merged commit de54be6 into main Mar 27, 2026
20 checks passed
@anthony-nhs anthony-nhs deleted the workflow_to_update_dev_container branch March 27, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants