Skip to content

Chore: [AEA-0000] - workflow to update dev container #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Mar 27, 2026
Merged

Chore: [AEA-0000] - workflow to update dev container #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/update_dev_container_version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Update Devcontainer Version

on:
workflow_dispatch:
schedule:
- cron: "0 18 * * 4"

Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this workflow can be triggered both on a schedule and manually (workflow_dispatch), two runs can overlap and potentially open duplicate/competing PRs. Consider adding a concurrency group (and optionally cancel-in-progress: true) to ensure only one update run executes at a time.

Suggested change
concurrency:
group: update-devcontainer-version
cancel-in-progress: true

Copilot uses AI. Check for mistakes.
jobs:
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6
permissions:
contents: read
packages: read
pull-requests: write
with:
base_branch: main
secrets:
CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}
Comment on lines +4 to +19
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation in this workflow uses 4+ spaces under on:/jobs: (e.g., workflow_dispatch, schedule, and the job definition). The rest of the workflows in this repo consistently use 2-space indentation, so aligning this file to that convention would improve readability and reduce diff noise in future edits.

Suggested change
workflow_dispatch:
schedule:
- cron: "0 18 * * 4"
jobs:
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6
permissions:
contents: read
packages: read
pull-requests: write
with:
base_branch: main
secrets:
CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}
workflow_dispatch:
schedule:
- cron: "0 18 * * 4"
jobs:
update_devcontainer_version:
uses: NHSDigital/eps-common-workflows/.github/workflows/update-dev-container-version.yml@23342d86a245c076937abd6aecdd0ce06446b1e6
permissions:
contents: read
packages: read
pull-requests: write
with:
base_branch: main
secrets:
CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}

Copilot uses AI. Check for mistakes.
Loading