Update ECR login command to use non-deprecated get-login-password#173
Merged
Conversation
get-login is deprecated
adrianclay
enabled auto-merge (squash)
August 12, 2024 12:01
martin-nhs
approved these changes
Aug 12, 2024
|
Just an aside, if the PR quality checks aren't something that is cared about - wouldn't it make sense to just remove these? 😄 |
Author
Agreed, and if it weren't for the fact this repo gets 1 commit every 6 months, I would be more motivated to invest the time into looking into it. 😓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
get-login is deprecated
Checklist
These are items (excluding GitHub Checks) which should be confirmed before a branch is ready to merge.