NIAD-3307: Changed the naming convention of branches to match the other adaptors#175
Merged
Merged
Conversation
morsh3d
approved these changes
Mar 11, 2025
stevenmccullaghmadetech
left a comment
stevenmccullaghmadetech
left a comment
There was a problem hiding this comment.
This RegEx has got a couple of questionable parts.
Firstly, it doesn't begin with "Starts With / ^", and there are discrepancies between the other adaptors' implementations. Finally, dependabot may autogenerate some branch names when performing updates, and these would be rejected. Perhaps worth checking whether this policy can be made uniform across all our adaptors.
morsh3d
suggested changes
Mar 12, 2025
morsh3d
left a comment
morsh3d
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes following Steven's review
stevenmccullaghmadetech
approved these changes
Mar 12, 2025
morsh3d
approved these changes
Mar 12, 2025
stevenmccullaghmadetech
approved these changes
Mar 12, 2025
stevenmccullaghmadetech
enabled auto-merge (squash)
March 12, 2025 12:46
Alex-Nita
force-pushed
the
NIAD-3307-fix-pipeline
branch
from
March 12, 2025 13:49
bfdefe6 to
05c1900
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the naming convention of branches to match the other adaptors
Jira Ticket
3307
Checklist
These are items (excluding GitHub Checks) which should be confirmed before a branch is ready to merge.