NIAD-3321: Update java to version 21#201
Merged
Merged
Conversation
* Update java / spring version to 21 in `build.gradle` * Update other packages to the latest compatible version in `build.gradle` * Update application.yml with compatible syntax for JMS on java 21.
* Update Gradle version to `8.7`
* Update `test.yml` in the GitHub workflow to use java 21 in all cases.
* Update `javax` packages to `jakarta`
* Update classes to `final` where required by checkstyle
* Update `CHANGELOG.md`.
* Update `README.md` to reflect the Java version updated.
* Update spotbugs to a version compatible with Java 21.
* Address bug `EI_EXPOSE_REP2: May expose internal representation by incorporating reference to mutable object This code stores a reference to an externally mutable object into the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Storing a copy of the object is better approach in many situations.`
Address bug: `This code stores a reference to an externally mutable object into the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Storing a copy of the object is better approach in many situations.`
MartinWheelerMT
force-pushed
the
niad-3321-bump-java-version
branch
from
April 25, 2025 09:49
11d2b51 to
3b0012a
Compare
* Supress false positive spotbugs warning for parameter dependency injection.
* Update java version in Dockerfile
* Fix issue .copy() and null when copying the bundle
* Update grade to 8.7 in `Dockerfile.tests`
* Revert spotbugs fix
* update hapi fhir base version in `build.gradle`
MartinWheelerMT
commented
Apr 25, 2025
| public Error(Message message, Exception e) { | ||
| super(message); | ||
| this.exception = exception; | ||
| this.exceptionMessage = e.getMessage(); |
Collaborator
Author
There was a problem hiding this comment.
Addresses spotbugs issue for mutable object
MartinWheelerMT
commented
Apr 25, 2025
|
|
||
| public Section(final List<String> edifactSegments) { | ||
| this.edifactSegments = edifactSegments; | ||
| this.edifactSegments = new ArrayList<>(edifactSegments); |
Collaborator
Author
There was a problem hiding this comment.
Addresses spot bugs issue relating to mutable objects.
* Suppress spotbugs warning for Bundle which is not accessed concurrently
* Suppress spotbugs warning for Bundle which is not accessed concurrently
* Dockerfile update
|
Images built and published to ECR using a Build Id of PR-57-697e8c6 |
MartinWheelerMT
changed the title
MartinWheelerMT
enabled auto-merge (squash)
April 25, 2025 13:24
Alex-Nita
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
build.gradle.build.gradle.8.7.test.ymlin the GitHub workflow to use java 21 in all cases.javaxpackages tojakarta.finalwhere required by CheckStyle.Jira Ticket
NIAD-3211: Bump Java Version
Checklist
These are items (excluding GitHub Checks) which should be confirmed before a branch is ready to merge.