generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
CCM-4893: Email journey component tests #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. So we have to boolean check the fields instead of relying on falsy.
bhansell1
commented
Oct 21, 2024
bhansell1
commented
Oct 21, 2024
bhansell1
commented
Oct 21, 2024
bhansell1
commented
Oct 21, 2024
bhansell1
commented
Oct 21, 2024
chris-elliott-nhsd
previously approved these changes
Oct 21, 2024
...s/test-team/template-mgmt-component-tests/email/template-mgmt-submit-email-page.component.ts
Outdated
Show resolved
Hide resolved
.../test-team/template-mgmt-component-tests/email/template-mgmt-preview-email-page.component.ts
Show resolved
Hide resolved
...s/test-team/template-mgmt-component-tests/email/template-mgmt-submit-email-page.component.ts
Outdated
Show resolved
Hide resolved
...s/test-team/template-mgmt-component-tests/email/template-mgmt-submit-email-page.component.ts
Show resolved
Hide resolved
sean-corrigan1
previously approved these changes
Oct 22, 2024
The base branch was changed.
chris-elliott-nhsd
approved these changes
Oct 23, 2024
sean-corrigan1
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds automated tests for
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.