Add Chat module for reading publication subscriber chats - #19
Closed
danwagnerco wants to merge 1 commit into
Closed
Conversation
Introduces Chat, ChatThread, and ChatMessage classes that provide read access to Substack community chat threads and messages. Requires authentication via SubstackAuth. Features: - Chat.get_threads() to list threads in a publication chat - ChatThread.get_messages() to read replies within a thread - Custom exceptions: ChatAuthenticationRequired, ChatAccessDenied, ChatNotFound, ThreadNotFound Includes API reference docs, user guide updates, and full test coverage with self-contained fixtures.
Owner
|
Thanks for this contribution! The code is clean and well-structured — the Chat → ChatThread → ChatMessage hierarchy fits nicely with the existing patterns in the library, and the test coverage and documentation are thorough. A few things I'd like to see addressed before merging:
|
amckenna
added a commit
to amckenna/substack_api
that referenced
this pull request
May 25, 2026
Introduces Chat, ChatThread, and ChatMessage classes providing read access to Substack community chat threads and messages via authenticated requests. Addresses all feedback from PR NHagar#19 review. Changes from original PR: - Remove unrelated .gitattributes, .gitignore, and uv.lock changes - Remove dead .claude/ fixture file paths from tests; use inline data only - Document limit param as client-side truncation in get_threads/get_messages - Accept subdomain string in Chat() and resolve to numeric ID automatically; falls back from the search API to the publication posts endpoint for publications not indexed by search - Add ChatPaymentRequired (subclass of ChatAccessDenied) for 402 responses, covering both missing paid subscriptions and insufficient subscription tiers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
Owner
|
Closing in favor of #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces Chat, ChatThread, and ChatMessage classes that provide read access to Substack community chat threads and messages. Requires authentication via SubstackAuth.
Features:
Includes API reference docs, user guide updates, and full test coverage with self-contained fixtures.