ci: skip musllinux and drop in-build wheel tests in release workflow by jonasteuwen · Pull Request #314 · NKI-AI/direct

jonasteuwen · 2026-08-06T15:55:57Z

PyTorch ships no musllinux wheels, so a musllinux direct wheel is not installable; skip it. Also drop cibuildwheel's in-build test, which would pip install the wheel with its full runtime stack (torch + CUDA wheels) just to run numpy-only native smoke tests. The dedicated smoke-wheels job already exercises the abi3 wheels with --no-deps on 3.12 and 3.13.

PyTorch ships no musllinux wheels, so a musllinux `direct` wheel is not installable; skip it. Also drop cibuildwheel's in-build test, which would `pip install` the wheel with its full runtime stack (torch + CUDA wheels) just to run numpy-only native smoke tests. The dedicated smoke-wheels job already exercises the abi3 wheels with --no-deps on 3.12 and 3.13. Co-authored-by: Cursor <cursoragent@cursor.com>

codecov · 2026-08-06T16:06:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.74%. Comparing base (cfa5fa8) to head (be47839).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files         110      110           
  Lines       10152    10152           
=======================================
  Hits         8603     8603           
  Misses       1549     1549

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The nanobind WrapDB subproject links the version-specific python3XY import library, so the Windows "abi3" wheel built on 3.12 imports python312.dll and fails to load on 3.13+ (DLL load failed). Build per-version wheels on Windows with -Dpython.allow_limited_api=false; keep a single abi3 wheel on Linux/macOS.

PyPI's description renderer disables the reStructuredText `raw` directive, so `twine check` (verify-metadata) rejected every artifact during publishing. Replace the raw HTML logo, badge bar, nav links, and figure with native RST (image/figure directives and badge substitutions) so the long_description renders on PyPI while still looking right on GitHub. Co-authored-by: Cursor <cursoragent@cursor.com>

The `direct` name on PyPI is taken, so publish under `direct-recon`. Only the distribution name changes; the import package stays `direct` (install_subdir), so `pip install direct-recon` then `import direct`. Update uv's no-build-isolation-package to the new distribution name, the wheel smoke-install name, the metadata-version test lookup, the PyPI install docs, and uv.lock. Co-authored-by: Cursor <cursoragent@cursor.com>

Surface `pip install direct-recon` as a first-class installation path (right after the recommended uv flow) instead of burying it inside the conda steps, clarifying that the import package is still `direct` and covering the editable install variant. Co-authored-by: Cursor <cursoragent@cursor.com>

Add `pip install direct-recon` as the primary install (uv shown for development) and a PyPI version badge, noting the import package stays `direct`. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

This PR updates the release CI to avoid producing/installing unusable musllinux wheels and to move wheel validation out of cibuildwheel’s in-build test step into the dedicated smoke test job. It also renames the PyPI distribution to direct-recon (while keeping the import package name direct) and updates docs/tests accordingly.

Changes:

Adjust release workflow wheel build matrix (abi3 on Linux/macOS; per-Python-version on Windows), skip musllinux, and drop cibuildwheel in-build wheel tests in favor of the existing smoke-wheels job.
Rename the project’s distribution name to direct-recon and update metadata/version test and install docs to match.
Regenerate uv.lock (including adding sys_platform != 'ios' markers to some CUDA-related deps).

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`uv.lock`	Updates locked dependencies and markers; reflects the renamed editable project entry.
`tests/version_test.py`	Updates the installed-metadata version check to use `direct-recon`.
`README.rst`	Switches to pure RST header/badges and documents `pip install direct-recon`.
`pyproject.toml`	Renames the distribution to `direct-recon` and updates uv no-build-isolation package name.
`installation.rst`	Adds/updates PyPI install instructions for `direct-recon`.
`.github/workflows/release.yml`	Skips musllinux, removes in-build wheel tests, adds Windows per-version wheel build, and relies on smoke-wheels for validation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

georgeyiasemis · 2026-08-07T12:15:36Z

 [project]
-name = "direct"
+# Distribution name on PyPI. The import package is still `direct` (see
+# meson.build / install_subdir), so `pip install direct-recon` then `import direct`.
+name = "direct-recon"
 description = "DIRECT - Deep Image REConsTruction - is a deep learning framework for MRI reconstruction."


Could you clarify what change you want in this thread—update the PR title/description, or revert/split the packaging rename changes?

apply suggestion

georgeyiasemis · 2026-08-07T11:51:26Z

+``DIRECT`` is published to PyPI as ``direct-recon`` (the import package is still
+``direct``). On the supported platforms this fetches a prebuilt ``abi3`` wheel,
+so nothing is compiled:


@copilot apply the suggestion

Updated in e7f8932. The installation docs now state that PyPI installs prebuilt wheels, with abi3 on Linux/macOS and Python-version-specific wheels on Windows.

Bump the version across pyproject.toml, meson.build, direct/__init__.py, and uv.lock (kept in sync by tests/version_test.py). Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: georgeyiasemis <71031687+georgeyiasemis@users.noreply.github.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: George Yiasemis <georgeyiasemis@hotmail.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/workflows/release.yml:104

The musllinux-skip rationale references a direct-recon wheel, but this repository/package is direct (and the rest of the workflow uses direct). This looks like a leftover name and makes the comment misleading.

          # Skip musllinux: PyTorch (a hard runtime dependency) publishes no
          # musllinux wheels, so a musllinux `direct-recon` wheel is not installable.
          CIBW_SKIP: "*-musllinux*"

pyproject.toml:80

The comment on no-build-isolation-package says it matches the distribution name "not the import package", but in this project they’re the same (direct). As written, it reads contradictory and can confuse future maintainers about what value is expected here.

# Build `direct` against the already-synced `build` group instead of an
# isolated build environment. Without this, meson-python's editable install
# records the absolute path of the isolated build env's `ninja`, which uv later
# deletes, breaking `import direct` on the next run. Matches the distribution
# name in `[project] name`, not the import package.

installation.rst:68

This section states that installing from PyPI fetches a prebuilt abi3 wheel. The release workflow builds per-version wheels on Windows, so the statement is inaccurate there. Rephrase to avoid implying Windows wheels are abi3.

``DIRECT`` is published to PyPI as ``direct``. On the supported platforms this
fetches a prebuilt ``abi3`` wheel, so nothing is compiled:

Co-authored-by: georgeyiasemis <71031687+georgeyiasemis@users.noreply.github.com>

jonasteuwen had a problem deploying to testpypi August 7, 2026 07:18 — with GitHub Actions Failure

jonasteuwen had a problem deploying to testpypi August 7, 2026 07:20 — with GitHub Actions Failure

jonasteuwen deployed to testpypi August 7, 2026 07:28 — with GitHub Actions Active

jonasteuwen and others added 3 commits August 7, 2026 09:41

docs: add PyPI install and badge for direct-recon to README

a11edef

Add `pip install direct-recon` as the primary install (uv shown for development) and a PyPI version badge, noting the import package stays `direct`. Co-authored-by: Cursor <cursoragent@cursor.com>

jonasteuwen requested a review from georgeyiasemis August 7, 2026 07:49

georgeyiasemis requested a review from Copilot August 7, 2026 08:05

Copilot started reviewing on behalf of georgeyiasemis August 7, 2026 08:05 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

release: bump version to 2.1.1

1feb166

Bump the version across pyproject.toml, meson.build, direct/__init__.py, and uv.lock (kept in sync by tests/version_test.py). Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot started work on behalf of georgeyiasemis August 7, 2026 11:06 View session

docs: clarify Windows wheel exception for limited-api note

f2d236b

Co-authored-by: georgeyiasemis <71031687+georgeyiasemis@users.noreply.github.com>

Copilot started work on behalf of georgeyiasemis August 7, 2026 11:08 View session

Copilot finished work on behalf of georgeyiasemis August 7, 2026 11:09

Copilot AI and others added 2 commits August 7, 2026 11:11

Revert distribution rename to keep PR scope on release CI

919a6d4

Co-authored-by: georgeyiasemis <71031687+georgeyiasemis@users.noreply.github.com>

Potential fix for pull request finding

be47839

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: George Yiasemis <georgeyiasemis@hotmail.com>

georgeyiasemis requested a review from Copilot August 7, 2026 11:12

Copilot started reviewing on behalf of georgeyiasemis August 7, 2026 11:13 View session

Copilot finished work on behalf of georgeyiasemis August 7, 2026 11:13

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Copilot started work on behalf of georgeyiasemis August 7, 2026 11:51 View session

docs: clarify Windows wheels are not abi3

e7f8932

Co-authored-by: georgeyiasemis <71031687+georgeyiasemis@users.noreply.github.com>

Copilot finished work on behalf of georgeyiasemis August 7, 2026 11:53

Copilot started work on behalf of georgeyiasemis August 7, 2026 12:00 View session

Copilot finished work on behalf of georgeyiasemis August 7, 2026 12:02

Copilot started work on behalf of georgeyiasemis August 7, 2026 12:15 View session

Copilot finished work on behalf of georgeyiasemis August 7, 2026 12:16

Copilot started work on behalf of georgeyiasemis August 7, 2026 12:16 View session

Copilot finished work on behalf of georgeyiasemis August 7, 2026 12:17

Copilot started work on behalf of georgeyiasemis August 7, 2026 12:41 View session

Copilot finished work on behalf of georgeyiasemis August 7, 2026 12:42

georgeyiasemis approved these changes Aug 7, 2026

View reviewed changes

jonasteuwen merged commit d111258 into main Aug 7, 2026
5 checks passed

jonasteuwen deleted the fix/release branch August 7, 2026 13:05

Navigation Menu

Uh oh!

ci: skip musllinux and drop in-build wheel tests in release workflow - #314

ci: skip musllinux and drop in-build wheel tests in release workflow#314
jonasteuwen merged 11 commits into
mainfrom
fix/release

jonasteuwen commented Aug 6, 2026

Uh oh!

codecov Bot commented Aug 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

georgeyiasemis Aug 7, 2026

Uh oh!

Copilot AI Aug 7, 2026

Uh oh!

georgeyiasemis Aug 7, 2026

Uh oh!

Uh oh!

georgeyiasemis Aug 7, 2026

Uh oh!

Copilot AI Aug 7, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jonasteuwen commented Aug 6, 2026

Uh oh!

codecov Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

georgeyiasemis Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

georgeyiasemis Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

georgeyiasemis Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Aug 6, 2026 •

edited

Loading