fixed ConfigureHiddenAssemblies not working for .NET Core 2.0#209
Closed
agentschmitt wants to merge 1 commit into
Closed
fixed ConfigureHiddenAssemblies not working for .NET Core 2.0#209agentschmitt wants to merge 1 commit into
agentschmitt wants to merge 1 commit into
Conversation
Member
|
Thanks, Isn't this an issue with the obsoletes? (the method is still not called in .NET core 2?) |
Author
|
The Obsoletes are also not working, cause the code inside of ConfigureHiddenAssemblies() is filtered out with the pre compiler condition (#if NETCORE1_0 && !NET451). So it is missing for NETCORE2_0. |
Contributor
|
Have created #210 |
Author
|
I think #210 is a more complete solution for the whole Nlog project. So i will close mine 👍 |
Contributor
|
@agentschmitt Nlog.Extensions.Logging 1.0.1 has now been released. You can test if it works for you |
Author
|
@snakefoot yes thx it is working now for .NET Core Application with HostBuilder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed ConfigureHiddenAssemblies not working for .NET Core 2.0 Applications.
This solves issue: NLog/NLog#2647