Skip to content

Introduced LoadConfigurationFromSection on ISetupBuilder#412

Merged
304NotModified merged 1 commit into
NLog:masterfrom
snakefoot:AddNLogLoggingConfigurationFactory
Mar 31, 2020
Merged

Introduced LoadConfigurationFromSection on ISetupBuilder#412
304NotModified merged 1 commit into
NLog:masterfrom
snakefoot:AddNLogLoggingConfigurationFactory

Conversation

@snakefoot
Copy link
Copy Markdown
Contributor

@snakefoot snakefoot commented Mar 31, 2020

Superseded #410

Updated example:

                LogManager.Setup()
                    .SetupExtensions(s => s.AutoLoadAssemblies(false))
                    .LoadConfigurationFromSection(config);

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #412 into master will decrease coverage by 0.15%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   82.45%   82.29%   -0.16%     
==========================================
  Files          14       14              
  Lines        1197     1192       -5     
  Branches      194      195       +1     
==========================================
- Hits          987      981       -6     
  Misses        141      141              
- Partials       69       70       +1
Impacted Files Coverage Δ
...Logging/Config/SetupExtensionsBuilderExtensions.cs 100% <100%> (ø)
...xtensions.Logging/Config/SetupBuilderExtensions.cs 88.88% <80%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8787454...e8993e9. Read the comment docs.

@304NotModified
Copy link
Copy Markdown
Member

This is an API breaking change? The revert?

@snakefoot
Copy link
Copy Markdown
Contributor Author

We have not released anything yet. Me trying out the LogManager.Setup()-fluent-API.

And decided that this works better for my eyes :)

@304NotModified
Copy link
Copy Markdown
Member

ow yes indeed

@304NotModified 304NotModified added this to the 1.6.3 milestone Mar 31, 2020
@304NotModified
Copy link
Copy Markdown
Member

This is indeed nicer to read :)

@304NotModified 304NotModified merged commit 4bd3bcb into NLog:master Mar 31, 2020
@304NotModified 304NotModified changed the title Reverted #410 and instead introduced LoadNLogConfigFromSection on ISetupBuilder Introduced LoadNLogConfigFromSection on ISetupBuilder Apr 14, 2020
snakefoot added a commit to snakefoot/NLog.Extensions.Logging that referenced this pull request Apr 26, 2020
snakefoot added a commit to snakefoot/NLog.Extensions.Logging that referenced this pull request Apr 26, 2020
snakefoot added a commit to snakefoot/NLog.Extensions.Logging that referenced this pull request May 10, 2020
304NotModified pushed a commit that referenced this pull request May 11, 2020
@304NotModified 304NotModified changed the title Introduced LoadNLogConfigFromSection on ISetupBuilder Introduced LoadConfigurationFromSection on ISetupBuilder May 11, 2020
@304NotModified
Copy link
Copy Markdown
Member

note renamed before release in #418. Example and title has been updated

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.29%. Comparing base (ef23abb) to head (e8993e9).
⚠️ Report is 336 commits behind head on master.

Files with missing lines Patch % Lines
...xtensions.Logging/Config/SetupBuilderExtensions.cs 80.00% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   82.45%   82.29%   -0.16%     
==========================================
  Files          14       14              
  Lines        1197     1192       -5     
  Branches      194      195       +1     
==========================================
- Hits          987      981       -6     
  Misses        141      141              
- Partials       69       70       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants