ci: fix x86 cross-compilation linker and artifact syntax ;#504
Merged
felixhekhorn merged 1 commit intoNNPDF:masterfrom Apr 14, 2026
Merged
ci: fix x86 cross-compilation linker and artifact syntax ;#504felixhekhorn merged 1 commit intoNNPDF:masterfrom
felixhekhorn merged 1 commit intoNNPDF:masterfrom
Conversation
Contributor
Author
|
Hi @scarlehoff, Sorry to bother you, could you please have a quick review on this isolated Maturin build fix from last week? The x86 cross-compilation passed locally, please let me know if any changes are required! ; |
felixhekhorn
approved these changes
Apr 14, 2026
Contributor
felixhekhorn
left a comment
There was a problem hiding this comment.
Seems good. Thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #502 , I've separated the immediate Maturin build fix from the OIDC in the PR ;
Changes
gcc-multilibconditionally for the Linux x86 target, resolving thecrti.olinker error that was preventing compilation.actions/download-artifactsyntax to v4 with the requiredpattern:block to resolve the failing release download step.Verification:
I ran an end-to-end mock release on my fork using a dummy tag.
readelfconfirmsClass: ELF32).