Fixing issue with try-except block #2402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've implemented the try-except block to catch possible failures in the computation of the systematic shifts. Note that now if either I'm done with this PR. Let's wait for the tests. Let me know if you spot anything silly or wrong. @scarlehoff @andrpie |
scarlehoff
approved these changes
Nov 11, 2025
Member
scarlehoff
left a comment
scarlehoff
left a comment
There was a problem hiding this comment.
LGTM
Make sure that the label is the right one!
Comment on lines
336
to
343
| if with_shift: | ||
| ax.set_title( | ||
| "{} {} (unshifted)".format(info.dataset_label, info.group_label(samefig_vals, info.figure_by)) | ||
| ) | ||
| else: | ||
| ax.set_title( | ||
| "{} {}".format(info.dataset_label, info.group_label(samefig_vals, info.figure_by)) | ||
| ) |
Member
There was a problem hiding this comment.
I think you swapped here shifted and unshifted ^^U
In any case, I would keep a single set_title and just set the string with the conditional like:
if with_shift:
shift_label = "(shifted)"
else:
shift_label = "(unshifted)"
ax.set_title(
"{} {} {}".format(info.dataset_label, info.group_label(samefig_vals, info.figure_by, shift_label))
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2399