Skip to content

Be more strict with checking for stat#2441

Merged
scarlehoff merged 1 commit intomasterfrom
be_more_strict_on_stat_decision
Mar 24, 2026
Merged

Be more strict with checking for stat#2441
scarlehoff merged 1 commit intomasterfrom
be_more_strict_on_stat_decision

Conversation

@scarlehoff
Copy link
Copy Markdown
Member

I think this is a bug although only a bunch of datasets were affected:

"ATLAS_Z0_8TEV_HIMASS_M-Y"
"ATLAS_1JET_7TEV_PTY-R06"
"ATLAS_1JET_7TEV_PTY-R04"
"ATLAS_1JET_8TEV_R06_PTY"

I've checked the chi2 of the first one and it doesn't change, but perhaps it would've had an effect on the shifts.
Basically before "stat" was treated separately. For the dataset that have the statistical uncertainty with another name that is not a problem (they are just an uncertainty) the problem is the ones that had "stat" as the starting of the name but were not actually "stat" (in its legacy meaning) which is the problem that @andrpie saw.

Now it checks for stat at the beginning of the word (just like before) but they are only accepted if they are also UNCORR and ADD. Hopefully this doesn't change the behaviour of old datasets that might rely on that and will also not introduce silent (or not that silent) bugs like in #2418

@scarlehoff scarlehoff requested a review from enocera March 20, 2026 11:43
@scarlehoff scarlehoff added the bug Something isn't working label Mar 20, 2026
@scarlehoff
Copy link
Copy Markdown
Member Author

@enocera sorry, I didn't ask you explicitly. Are you ok with having this check, should I merge this?

@enocera
Copy link
Copy Markdown
Contributor

enocera commented Mar 24, 2026

Please proceed and merge.

@scarlehoff scarlehoff force-pushed the be_more_strict_on_stat_decision branch from f237e06 to dbb414e Compare March 24, 2026 14:30
@scarlehoff scarlehoff merged commit e892b82 into master Mar 24, 2026
12 checks passed
@scarlehoff scarlehoff deleted the be_more_strict_on_stat_decision branch March 24, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants