Be more strict with checking for stat#2441
Merged
scarlehoff merged 1 commit intomasterfrom Mar 24, 2026
Merged
Conversation
Member
Author
|
@enocera sorry, I didn't ask you explicitly. Are you ok with having this check, should I merge this? |
Contributor
|
Please proceed and merge. |
…UNCORR they will be understood as stat
f237e06 to
dbb414e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is a bug although only a bunch of datasets were affected:
I've checked the chi2 of the first one and it doesn't change, but perhaps it would've had an effect on the shifts.
Basically before "stat" was treated separately. For the dataset that have the statistical uncertainty with another name that is not a problem (they are just an uncertainty) the problem is the ones that had "stat" as the starting of the name but were not actually "stat" (in its legacy meaning) which is the problem that @andrpie saw.
Now it checks for
statat the beginning of the word (just like before) but they are only accepted if they are alsoUNCORRandADD. Hopefully this doesn't change the behaviour of old datasets that might rely on that and will also not introduce silent (or not that silent) bugs like in #2418