Skip to content

Enable bias correction for aerosol DA #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ypwang19 wants to merge 9 commits into from
Closed

Enable bias correction for aerosol DA #3189

ypwang19 wants to merge 9 commits into from

Conversation

@ypwang19
Copy link
Contributor

@ypwang19 ypwang19 commented Dec 20, 2024 •
edited
Loading

Description

This PR enables the capability of bias correction for aerosol DA in the workflow.

Resolves #3172
Refs #2875

Type of change

  • New feature (adds functionality)

Change characteristics

How has this been tested?

  • Cycled test on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@RussTreadon-NOAA
Copy link
Contributor

RussTreadon-NOAA commented Dec 23, 2024

@ypwang19: Do we have PRs in GDASApp and jcb-gdas for the changes required by this PR? If yes, we should cite these PRs in this g-w PR. Then the g-w team and others can see when the prerequisite PRs are merged.

@ypwang19
Copy link
Contributor Author

ypwang19 commented Dec 23, 2024

@ypwang19: Do we have PRs in GDASApp and jcb-gdas for the changes required by this PR? If yes, we should cite these PRs in this g-w PR. Then the g-w team and others can see when the prerequisite PRs are merged.

Yes, we have. I am going to open PRs in GDASApp and jcb-gdas soon and will cite them here.

This was referenced Dec 23, 2024
Merged
Merged
CoryMartin-NOAA added a commit to NOAA-EMC/GDASApp that referenced this pull request Jan 2, 2025
@ypwang19 @CoryMartin-NOAA
Update jcb-base for aerosol VarBC (#1426)
bd97af9 
# Description

This PR adds the aerosol bias file names to the jcb-base template.

# Companion PRs
NOAA-EMC/global-workflow#3189

# Issues
Resolves #NOAA-EMC/global-workflow#3172


# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] C96C48_hybatmaerosnowDA  <!-- JEDI aero/snow cycled DA !-->

---------

Co-authored-by: ypwang19 <yaping.wang@users.noreply.github.com>
Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
CoryMartin-NOAA added a commit to NOAA-EMC/jcb-gdas that referenced this pull request Jan 3, 2025
@ypwang19 @CoryMartin-NOAA
Update YAMLs for aerosol VarBC (#61)
10a744a 
This PR updates jcb yamls for aerosol variational bias correction. 

Will add the obs bias section to yamls in observations/aero/ later as
more work is needed to select proper predictors.

Companion PRs:
 - NOAA-EMC/GDASApp#1426
 - NOAA-EMC/global-workflow#3189

Co-authored-by: ypwang19 <yaping.wang@users.noreply.github.com>
Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
@RussTreadon-NOAA
Copy link
Contributor

RussTreadon-NOAA commented Jan 3, 2025

@ypwang19 , now that

have been merged into their respective develop, we need to update the GDASApp develop hash for parm/jcb-gdas to point at the new head, 10a744a of jcb-gdas develop

Once this is done the sorc/gdas.cd hash in ypwang19:feature/aero-varbc needs to be updated to point at the new GDASApp develop.

@ypwang19
Copy link
Contributor Author

ypwang19 commented Jan 3, 2025

@ypwang19 , now that

have been merged into their respective develop, we need to update the GDASApp develop hash for parm/jcb-gdas to point at the new head, 10a744a of jcb-gdas develop

Once this is done the sorc/gdas.cd hash in ypwang19:feature/aero-varbc needs to be updated to point at the new GDASApp develop.

I am not sure how to update the hash.
Do we need to open a PR in GDASApp and update the hash for the first step, then open a PR in global-workflow and update to the new GDASApp for the second step?

@CoryMartin-NOAA
Copy link
Contributor

CoryMartin-NOAA commented Jan 3, 2025

@ypwang19 yes, I'll message you on Slack about how to do this.

@ypwang19 ypwang19 marked this pull request as ready for review January 3, 2025 21:07
@CoryMartin-NOAA
Copy link
Contributor

CoryMartin-NOAA commented Jan 6, 2025

@ypwang19 could you update the values in https://github.com/NOAA-EMC/global-workflow/blob/develop/parm/config/gfs/config.aeroanlgenb as part of this PR? The numbers in develop work at low resolution but are too slow at higher resolution. We should use what you and @andytangborn are using

@ypwang19
Copy link
Contributor Author

ypwang19 commented Jan 6, 2025

@ypwang19 could you update the values in https://github.com/NOAA-EMC/global-workflow/blob/develop/parm/config/gfs/config.aeroanlgenb as part of this PR? The numbers in develop work at low resolution but are too slow at higher resolution. We should use what you and @andytangborn are using

Sure, I just updated the numbers to what we are using.

@CoryMartin-NOAA
Copy link
Contributor

CoryMartin-NOAA commented Jan 6, 2025

@ypwang19 thanks!

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Jan 6, 2025
View reviewed changes
WalterKolczynski-NOAA
WalterKolczynski-NOAA requested changes Jan 8, 2025
View reviewed changes
@ypwang19 @WalterKolczynski-NOAA
Update jobs/JGLOBAL_AERO_ANALYSIS_INITIALIZE
533130c 
Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
@ypwang19 ypwang19 marked this pull request as draft January 8, 2025 18:49
@RussTreadon-NOAA RussTreadon-NOAA added the JEDI Feature development to support JEDI-based DA label Feb 8, 2025
@RussTreadon-NOAA RussTreadon-NOAA modified the milestone: GFS v17 Feb 8, 2025
@DavidNew-NOAA DavidNew-NOAA mentioned this pull request Mar 10, 2025
Merged
22 tasks
@ypwang19 ypwang19 closed this May 13, 2025
@ypwang19 ypwang19 deleted the feature/aero-varbc branch May 13, 2025 15:36
DavidNew-NOAA pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Jan 6, 2026
@ypwang19 @CoryMartin-NOAA
Update YAMLs for aerosol VarBC (#61)
23b7d15 
This PR updates jcb yamls for aerosol variational bias correction. 

Will add the obs bias section to yamls in observations/aero/ later as
more work is needed to select proper predictors.

Companion PRs:
 - #1426
 - NOAA-EMC/global-workflow#3189

Co-authored-by: ypwang19 <yaping.wang@users.noreply.github.com>
Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA requested changes

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA left review comments

@DavidNew-NOAA DavidNew-NOAA Awaiting requested review from DavidNew-NOAA DavidNew-NOAA is a code owner

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA will be requested when the pull request is marked ready for review DavidHuber-NOAA is a code owner

@aerorahul aerorahul Awaiting requested review from aerorahul aerorahul will be requested when the pull request is marked ready for review aerorahul is a code owner

Assignees

@ypwang19 ypwang19

Labels

JEDI Feature development to support JEDI-based DA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle VarBC files for aerosol DA

4 participants

@ypwang19 @RussTreadon-NOAA @CoryMartin-NOAA @WalterKolczynski-NOAA