Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Mar 28, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added ⤵️ pull merge-conflict Resolve conflicts manually labels Mar 28, 2023
aurac and others added 28 commits June 14, 2023 12:02
This PR was submitted for the 6.3 branch but it was merged into the 6.2 branch instead.

Discussion
----------

[Bundles] Update wording bundles.rst

Commits
-------

b15303f Update wording bundles.rst
This PR was submitted for the 6.3 branch but it was merged into the 6.2 branch instead.

Discussion
----------

[Security] Update security.rst

Typo!

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

fa355fd Update security.rst
use constant of class and not string (in twig too)
This PR was submitted for the 6.4 branch but it was merged into the 6.2 branch instead.

Discussion
----------

[Security] Update voters.rst

use constant of class and not string (in twig too)

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

1799a49 Update voters.rst
…es by their source code link (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[HttpClient] Replace a few classes and methods occurrences by their source code link

Fixing a few missing ones

Commits
-------

335c8cf [HttpClient] Replace a few classes and methods occurrences by their source code link
* 5.4:
  [HttpClient] Replace a few classes and methods occurrences by their source code link
…ption (alexandre-daubois)

This PR was submitted for the 6.4 branch but it was merged into the 5.4 branch instead.

Discussion
----------

[Process] Remove wrong note about `create_new_console` option

Fix #18414

Commits
-------

68642ae [Process] Remove wrong note about `create_new_console` option
* 5.4:
  [Process] Remove wrong note about `create_new_console` option
…r.rst (Manually Wiring Arguments part) (Enz000)

This PR was merged into the 6.2 branch.

Discussion
----------

[DependencyInjection] fix(typo): Update service_container.rst (Manually Wiring Arguments part)

Commits
-------

40d2bb7 Update service_container.rst (Manually Wiring Arguments part)
…ndre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Console] Call command with options without value

Also added `:class:` to `BufferedOutput`, as it's not referenced anywhere else in the page

Commits
-------

b55fcfb [Console] Call command with options without value
* 5.4:
  [Console] Call command with options without value
… support for wildcard routes (brzuchal)

This PR was submitted for the 6.3 branch but it was merged into the 6.2 branch instead.

Discussion
----------

[FrameworkBundle][Messenger] Extend note on routing with support for wildcard routes

Extend wildcard `'*'` note with information about the usage of namespace wildcards.

Commits
-------

c4e2655 [Messenger] Extend note on routing with support for wildcard routes
added additional information
…ly does (scuben)

This PR was merged into the 6.2 branch.

Discussion
----------

[HtmlSanitizer] corrected what `force_https_urls` actually does

As seen in the [code](https://github.com/symfony/html-sanitizer/blob/eae9b0a9ad7a2ed1963f819547d59ff99ad9e0fd/TextSanitizer/UrlSanitizer.php#L68-L71) this only converts `http://` to `https://` but does not change any other scheme.

Commits
-------

b9a74c0 correct usage of force_https_urls
…hosts (they also match) (scuben)

This PR was merged into the 6.2 branch.

Discussion
----------

[HtmlSanitizer] Information about subdomains of allowed hosts (they also match)

As seen in the [code](https://github.com/symfony/html-sanitizer/blob/6.2/TextSanitizer/UrlSanitizer.php#L108-L135) the allowed hosts also match any subdomain.

Commits
-------

9e3d225 subdomains are also allowed on allowed hosts
This PR was merged into the 6.2 branch.

Discussion
----------

[Form] Update dynamic_form_modification.rst

Hi mates,

The JavaScript parts use jQuery and, IMHO, it's not relevant. Also, performing an Ajax request is easier since fetch is available for JavaScript. That's why I propose this piece of code.

Also, to use `form.getAttribute('action')` , you must manually define the URL called by the form. To do this, I give a third parameter to `createForm` and I set the action value in `SportMeetupType` with `$builder->setAction()`

Yannick

Commits
-------

7b5868b Update dynamic_form_modification.rst
OskarStark and others added 30 commits July 25, 2023 12:47
This PR was submitted for the 6.3 branch but it was merged into the 6.2 branch instead.

Discussion
----------

[Mailer] Fix typo

Commits
-------

705cf3f [Mailer] Fix typo
This PR was merged into the 6.2 branch.

Discussion
----------

[FrameworkBundle] Fix merging typos

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

f5a899e [FrameworkBundle] Fix merging typos
…iner compilation (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] Add note for `prefix_seed` about container compilation

Fix #18609

Commits
-------

5190cbb [FrameworkBundle] Add note for `prefix_seed` about container compilation
* 5.4:
  [FrameworkBundle] Add note for `prefix_seed` about container compilation
This PR was merged into the 5.4 branch.

Discussion
----------

[Form] Improve form type guessers section

Commits
-------

45b56c4 [Form] Improve form type guessers section
* 5.4:
  [Form] Improve form type guessers section
Using RedisTagAwareAdapter, Redis maxmemory-policy has to be "noeviction" or "volatile-*"
This PR was submitted for the 6.3 branch but it was merged into the 6.2 branch instead.

Discussion
----------

[Cache] Update redis_adapter.rst

Using RedisTagAwareAdapter, Redis maxmemory-policy has to be "noeviction" or "volatile-*"

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

27ef0be Update redis_adapter.rst
This PR was merged into the 5.4 branch.

Discussion
----------

Fix some internal references

Commits
-------

e3edb9c Fix some internal references
* 5.4:
  Fix some internal references
This PR was merged into the 5.4 branch.

Discussion
----------

fix syntax

Commits
-------

0125534 fix syntax
* 5.4:
  fix syntax
…egisterLoader (IssamRaouf)

This PR was merged into the 5.4 branch.

Discussion
----------

[micro_kernel] Fix deleted feature AnnotationRegistry::registerLoader

[Dropping AnnotationRegistry completely, relying on native autoloading instead](doctrine/annotations#205) v2.0.0

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

9168b9d [micro_kernel] Fix deleted method AnnotationRegistry::registerLoader
* 5.4:
  [micro_kernel] Fix deleted method AnnotationRegistry::registerLoader
This PR was merged into the 5.4 branch.

Discussion
----------

Remove some unused use

Found when working on #18633

Commits
-------

546fc2f Remove some unused use
* 5.4:
  Remove some unused use
* 5.4:
  Backport a fix related to Webpack Encore
This PR was submitted for the 6.4 branch but it was squashed and merged into the 6.2 branch instead.

Discussion
----------

Fix $tags type

$tags using in the documentation must be a Collection to be persisted.

Commits
-------

88655a9 Fix $tags type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⤵️ pull merge-conflict Resolve conflicts manually

Projects

None yet

Development

Successfully merging this pull request may close these issues.