-
Notifications
You must be signed in to change notification settings - Fork 64
Add CST and HighTempThermalStorage, and Update Defaults #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Needed for NSRDB API call within SAM SSC for CST
…o add-cst-reopt
…nary (TBD if it needs to be)
…o add-cst-reopt
reoptjl/custom_table_config.py
Outdated
| "label" : "CST Total Electricity Produced (kWh/yr)", | ||
| "key" : "cst_total_electricity_produced", | ||
| "bau_value" : lambda df: safe_get(df, "outputs.CST.annual_electric_production_kwh_bau"), | ||
| "scenario_value": lambda df: safe_get(df, "outputs.CST.annual_electric_production_kwh") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtkadlec Is this actually a CST output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bill-Becker it is yes. Here is where it's defined: https://github.com/NREL/REopt.jl/blob/add-cst-reopt/src/results/cst.jl#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice use of the permalink to the line!! :-) But that's pointing the consumption, not production...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right and I missed this! this has been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Concentrating Solar Thermal (CST) and High Temperature Thermal Storage technologies, and updates various financial and technology default values to align with the latest REopt.jl implementation.
- Adds CST and HighTempThermalStorage models with complete input/output functionality
- Updates default values across multiple technology and financial parameters
- Integrates the new technologies into views, validators, and result processing workflows
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| reoptjl/views.py | Adds CST and HighTempThermalStorage to help, outputs, and results endpoints |
| reoptjl/validators.py | Updates validator imports to include new CST and HighTempThermalStorage models |
| reoptjl/test/ | Updates test expectations for new default values and adds CST/HighTempTES fields to summary |
| reoptjl/src/process_results.py | Adds processing logic for CST and HighTempThermalStorage outputs |
| reoptjl/models.py | Defines CST and HighTempThermalStorage model classes and updates defaults across technologies |
| reoptjl/migrations/ | Database migration files for new models and updated defaults |
| reoptjl/custom_table_config.py | Adds CST and HighTempThermalStorage metrics to custom table configuration |
| julia_src/ | Updates Julia environment and dependencies to support new features |
| CHANGELOG.md | Documents all changes and new features |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| d["Messages"] = REoptjlMessageOutputs.info_dict(REoptjlMessageOutputs) | ||
| d["SteamTurbine"] = SteamTurbineOutputs.info_dict(SteamTurbineOutputs) | ||
| d["CST"] = CSTOutputs.info_dict(CSTOutputs) | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Adds
CST(concentrating solar thermal) andHighTempThermalStoragetechnology models from this REopt.jl PR:Also merged defaults update PR: