Skip to content

Conversation

@Bill-Becker
Copy link
Collaborator

@Bill-Becker Bill-Becker commented Aug 25, 2025

Adds CST (concentrating solar thermal) and HighTempThermalStorage technology models from this REopt.jl PR:

Also merged defaults update PR:

Kadlec and others added 30 commits April 16, 2025 15:01
Needed for NSRDB API call within SAM SSC for CST
@Bill-Becker Bill-Becker changed the title Add cst reopt Add Concentrating Solar Thermal (CST) and HighTempThermalStorage Sep 5, 2025
"label" : "CST Total Electricity Produced (kWh/yr)",
"key" : "cst_total_electricity_produced",
"bau_value" : lambda df: safe_get(df, "outputs.CST.annual_electric_production_kwh_bau"),
"scenario_value": lambda df: safe_get(df, "outputs.CST.annual_electric_production_kwh")
Copy link
Collaborator Author

@Bill-Becker Bill-Becker Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtkadlec Is this actually a CST output?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice use of the permalink to the line!! :-) But that's pointing the consumption, not production...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right and I missed this! this has been removed.

@Bill-Becker Bill-Becker marked this pull request as ready for review September 23, 2025 20:09
@Bill-Becker Bill-Becker changed the title Add Concentrating Solar Thermal (CST) and HighTempThermalStorage Add CST and HighTempThermalStorage models, and Update Defaults Sep 24, 2025
@Bill-Becker Bill-Becker changed the title Add CST and HighTempThermalStorage models, and Update Defaults Add CST and HighTempThermalStorage, and Update Defaults Sep 24, 2025
@Bill-Becker Bill-Becker requested a review from Copilot September 24, 2025 14:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Concentrating Solar Thermal (CST) and High Temperature Thermal Storage technologies, and updates various financial and technology default values to align with the latest REopt.jl implementation.

  • Adds CST and HighTempThermalStorage models with complete input/output functionality
  • Updates default values across multiple technology and financial parameters
  • Integrates the new technologies into views, validators, and result processing workflows

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
reoptjl/views.py Adds CST and HighTempThermalStorage to help, outputs, and results endpoints
reoptjl/validators.py Updates validator imports to include new CST and HighTempThermalStorage models
reoptjl/test/ Updates test expectations for new default values and adds CST/HighTempTES fields to summary
reoptjl/src/process_results.py Adds processing logic for CST and HighTempThermalStorage outputs
reoptjl/models.py Defines CST and HighTempThermalStorage model classes and updates defaults across technologies
reoptjl/migrations/ Database migration files for new models and updated defaults
reoptjl/custom_table_config.py Adds CST and HighTempThermalStorage metrics to custom table configuration
julia_src/ Updates Julia environment and dependencies to support new features
CHANGELOG.md Documents all changes and new features
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

d["Messages"] = REoptjlMessageOutputs.info_dict(REoptjlMessageOutputs)
d["SteamTurbine"] = SteamTurbineOutputs.info_dict(SteamTurbineOutputs)
d["CST"] = CSTOutputs.info_dict(CSTOutputs)

This comment was marked as off-topic.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Bill-Becker Bill-Becker merged commit 3629e1c into develop Sep 24, 2025
1 check passed
@Bill-Becker Bill-Becker deleted the add-cst-reopt branch September 25, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants