Upgrade dependencies and Fix imports #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades dependencies and applies ruff linter fixes to clean up the import order and remove unused or duplicate imports.
- Consolidated and reordered import statements across multiple files
- Removed deprecated or unused imports based on linter recommendations
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/nsls2api/services/facility_service.py | Reordered imports to comply with style and linter rules |
| src/nsls2api/services/bnlpeople_service.py | Adjusted import order and modified exception handling for cleaner logging |
| src/nsls2api/models/proposals.py | Removed an unused import to streamline code |
| src/nsls2api/models/pass_models.py | Reordered pydantic import placement per linter suggestions |
| src/nsls2api/models/jobs.py | Updated import order by moving StrEnum import to the top |
| src/nsls2api/models/apikeys.py | Reordered Beanie imports for consistency |
| src/nsls2api/models/init.py | Reordered module imports to reflect updated dependency requirements |
| src/nsls2api/local_cli.py | Consolidated multiple separate import statements into one line |
| src/nsls2api/infrastructure/security.py | Reordered imports and updated the fastapi import sequence |
| src/nsls2api/infrastructure/config.py | Updated import ordering and added a logging statement for the settings file |
| src/nsls2api/exception_handlers.py | Reordered the import of the main app for clarity |
| src/nsls2api/cli/cli.py | Consolidated CLI imports for readability |
| src/nsls2api/cli/auth.py | Eliminated duplicate imports and reordered module imports |
| src/nsls2api/api/v1/stats_api.py | Adjusted the order of imported models as per linter fixes |
| src/nsls2api/api/v1/jobs_api.py | Minor formatting adjustments in import organization |
| src/nsls2api/api/v1/facility_api.py | Reordered service imports to maintain consistency |
| src/nsls2api/api/models/stats_model.py | Applied minor formatting changes to import spacing |
| src/nsls2api/api/models/person_model.py | Reordered typing imports for consistency |
| src/nsls2api/api/models/facility_model.py | Made minor adjustments to import layout |
Files not reviewed (1)
- requirements-dev.txt: Language not supported
stuartcampbell
requested review from
JunAishima,
danielballan and
padraic-shafer
padraic-shafer
approved these changes
Apr 9, 2025
Collaborator
Author
|
Thank you @padraic-shafer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a regular update to the latest version of dependencies.
Also, applied
rufflinter fixes - which are pretty much cleaning up imports.