Various improvements relating to Slack integration #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d improve error handling
… conversation data handling
…details and log conversation information
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhances the Slack integration for proposal channels by introducing detailed conversation retrieval and updating the GET endpoint to return richer channel information.
- Added
SlackConversationmodel andget_conversation_detailsservice to fetch full channel details including members. - Enriched
get_user_infowith bot status, real name, and pending invitation; increasedconversations_memberslimit. - Modified
/v1/proposal/{proposal_id}/slack-channelsendpoint to returnSlackConversationobjects viaget_conversation_details.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/nsls2api/services/slack_service.py | Introduce get_conversation_details, enhance get_user_info, adjust member retrieval, rename function |
| src/nsls2api/models/slack_models.py | Add SlackConversation and SlackUserProfile Pydantic models |
| src/nsls2api/api/v1/proposal_api.py | Change endpoint return type to SlackConversation and incorporate new service |
Comments suppressed due to low confidence (1)
src/nsls2api/services/slack_service.py:328
- Remove the
/1000.0division since Slack'supdatedtimestamp is in seconds, not milliseconds, to avoid incorrect date calculations.
info_response.get("channel", {}).get("updated", 0) / 1000.0
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nmaytan
requested changes
Jul 22, 2025
Collaborator
nmaytan
left a comment
nmaytan
left a comment
There was a problem hiding this comment.
I looked through this and have just a couple suggestions
Co-authored-by: Nathanael (Nate) Maytan <mr.maytan@gmail.com>
Co-authored-by: Nathanael (Nate) Maytan <mr.maytan@gmail.com>
…in requirements-dev.txt
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nmaytan
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main improvement in this PR is to increase the usefulness of the GET endpoint
/v1/proposal/{proposal_id}/slack-channels.This will resolve #186.