-
Notifications
You must be signed in to change notification settings - Fork 13
Added current cycle automation changes to cycles sync process #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added current cycle automation changes to cycles sync process #199
Conversation
|
Would it make sense to take the logic within |
Yeah that makes sense, since this api will be not called directly, it is better to add it in existing method. I'll update and let you know. |
I have added the changes to worker_synchronize_cycles_from_pass and removed the apis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the cycle synchronization process by automatically setting the current operating cycle based on today's date after syncing cycles from PASS. The changes ensure that the facility's current cycle is updated to match the cycle that contains the current date.
- Added functionality to find cycles by date range
- Enhanced cycle synchronization to automatically set current operating cycle
- Improved documentation and logging for the sync process
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/nsls2api/services/sync_service.py | Enhanced worker_synchronize_cycles_from_pass to set current cycle after sync and improved documentation |
| src/nsls2api/services/facility_service.py | Added facility_cycle_by_date function to find cycles containing a specific date |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
padraic-shafer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. I suggested some minor copyedits in the comments.
Co-authored-by: Padraic Shafer <76011594+padraic-shafer@users.noreply.github.com>
Co-authored-by: Padraic Shafer <76011594+padraic-shafer@users.noreply.github.com>
I have applied the changes. |
Added: