Skip to content

Enable CLI to bypass required flag "--beamline" if specified in env#190

Open
Kari Barry (Kezzsim) wants to merge 2 commits intoNSLS2:mainfrom
Kezzsim:utilize_acronym
Open

Enable CLI to bypass required flag "--beamline" if specified in env#190
Kari Barry (Kezzsim) wants to merge 2 commits intoNSLS2:mainfrom
Kezzsim:utilize_acronym

Conversation

@Kezzsim
Copy link
Copy Markdown
Collaborator

Resolves #189 by adding additional parsing logic to the CLI component which will get the beamline from the environment variable BEAMLINE_ACRONYM.

Some design consciderations:

  • This is implemented in the CLI args parser section as to allow the user to still override the env var with an argument if needed, this seems like it would be more intuitive.
  • Because of this decision, when invoking the function from within another python program; beamline will still need to be provided. This shouldn't be a huge deal because python scripting is automated and will be run by the machine and not a human. This entire endeavor is an ergonomic concern.

Comment thread nslsii/sync_experiment/sync_experiment.py Outdated
@tacaswell
Copy link
Copy Markdown
Contributor

Is this still a going concern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use BEAMLINE_ACRONYM as default

3 participants