Merge template#19
Merged
Merged
Conversation
# Conflicts: # .github/workflows/release.yml
… nor in vcpkg-configuration.json
…ne was not found nor in vcpkg.json nor in vcpkg-configuration.json
add model option for driver
try Ninja
# Conflicts: # .github/workflows/release.yml # app/include/Structs.h # app/src/Driver.cpp # include/PropLibTemplate.h # src/ReturnCodes.cpp
add model test
# Conflicts: # app/include/ReturnCodes.h # app/src/Driver.cpp # app/tests/TestDriver.cpp
jodumkeNTIA
reviewed
Jun 23, 2026
| * | ||
| * @return Library name string. | ||
| ******************************************************************************/ | ||
| char *GetLibraryNameCharArray() { |
Collaborator
There was a problem hiding this comment.
Good job adding these functions for library and version names.
jodumkeNTIA
approved these changes
Jun 23, 2026
jodumkeNTIA
left a comment
jodumkeNTIA
left a comment
Collaborator
There was a problem hiding this comment.
Good job, tests still work and all changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.