Skip to content

Remove index.md markdown to prevent 3.13 requirement#1076

Merged
pstjohn merged 1 commit into
mainfrom
jwilber/mdformat-python313-reversion
Aug 26, 2025
Merged

Remove index.md markdown to prevent 3.13 requirement#1076
pstjohn merged 1 commit into
mainfrom
jwilber/mdformat-python313-reversion

Conversation

@jwilber
Copy link
Copy Markdown
Collaborator

@jwilber jwilber commented Aug 26, 2025

The cards in the docs index.md require a specific format.
However, mdformat changes this format. To workaround this, we had to add excludes functionalty for mdformat that prevented it from formatting index.md. For some reason, the excludes functionality in mdformat which requires python 3.13. This is broke our nightly build.

To fix this, I've converted the index.md card logic from markdown to html, so that it no longer gets formatted. This removes the need for the excludes functionality and the 3.13 dependency it brings.

Signed-off-by: Jared Wilber <jwilber@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Aug 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jwilber
Copy link
Copy Markdown
Collaborator Author

jwilber commented Aug 26, 2025

/ok to test 641b1cb

Copy link
Copy Markdown
Collaborator

@cspades cspades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to approve, the code was a bit hard to look at, approving minimizes those boxes. /s

(Also, how do you get that... byte code (?) from an SVG, can we always do this with any SVG we find?)

@pstjohn
Copy link
Copy Markdown
Collaborator

pstjohn commented Aug 26, 2025

all relevant CI has passed, merging to save some time

@pstjohn pstjohn merged commit 2ec4064 into main Aug 26, 2025
23 checks passed
@pstjohn pstjohn deleted the jwilber/mdformat-python313-reversion branch August 26, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants