Skip to content

temporarily comment out failing checkpoint#1093

Merged
pstjohn merged 3 commits into
mainfrom
jwilber/temporarily-xfail-evo2-test
Aug 29, 2025
Merged

temporarily comment out failing checkpoint#1093
pstjohn merged 3 commits into
mainfrom
jwilber/temporarily-xfail-evo2-test

Conversation

@jwilber
Copy link
Copy Markdown
Collaborator

@jwilber jwilber commented Aug 29, 2025

temporarily comment out failing checkpoint

Summary by CodeRabbit

  • Tests
    • Disabled the "evo2/7b-1m:1.0" scenario in three parameterized tests (batch generate, batch generate for coding sequences, and generate speed) by commenting out the case. The entry remains for future reference. No user-facing functionality is affected; only test execution is adjusted. This change has no impact on installation or runtime behavior.

Signed-off-by: Jared Wilber <jwilber@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Aug 29, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A single test file was modified to comment out the evo2/7b-1m:1.0 parameter across three parameterized tests, effectively disabling that case in test_batch_generate, test_batch_generate_coding_sequences, and test_generate_speed. No other logic or files were changed.

Changes

Cohort / File(s) Summary
Tests: Disable specific parameter case
sub-packages/bionemo-evo2/tests/bionemo/evo2/test_evo2.py
Commented out the evo2/7b-1m:1.0 case in three parameterized tests: batch generate, coding sequences generation, and generate speed. No other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I thump my paw: test burrow’s neat,
One nibble trimmed, a silent seat.
The 7b hop now takes a rest,
Carrots count the passing test.
With whiskers twitch and builds that pass,
I bound ahead through meadow grass. 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 720a732 and b21b7a1.

📒 Files selected for processing (1)
  • sub-packages/bionemo-evo2/tests/bionemo/evo2/test_evo2.py (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jwilber/temporarily-xfail-evo2-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jwilber
Copy link
Copy Markdown
Collaborator Author

jwilber commented Aug 29, 2025

/ok to test 6b11143

Signed-off-by: Jared Wilber <jwilber@nvidia.com>
@pstjohn
Copy link
Copy Markdown
Collaborator

pstjohn commented Aug 29, 2025

Force-merging at Jared's request 🤣

@pstjohn pstjohn merged commit 345d3cc into main Aug 29, 2025
7 of 8 checks passed
@pstjohn pstjohn deleted the jwilber/temporarily-xfail-evo2-test branch August 29, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants