GH200 support#369
Merged
Merged
Conversation
gagank1
requested review from
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
trvachov
reviewed
Dec 9, 2024
Collaborator
trvachov
left a comment
trvachov
left a comment
There was a problem hiding this comment.
Looks good -- I asked a few questions to just understand where things are coming from. Thanks!
skothenhill-nv
approved these changes
Dec 9, 2024
trvachov
approved these changes
Dec 10, 2024
Contributor
Author
|
/build-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for GH200 machines.
Summary
Most of the differences between Dockerfile.arm and Dockerfile involve building packages that are either not available on ARM or don't work for some reason the way they are available on ARM.
Usage
Usage is the same as the normal framework container. It will build and run on GH200 machines now.
Testing
All the existing tests pass on GH200 machines (except for this known bug which results in 1 failure).
Tests for these changes can be run via:
./ci/scripts/run_pytest.sh