initial config for partial conv in JET of esm2 in bionemo2#428
Closed
dorotat-nv wants to merge 24 commits into
Closed
initial config for partial conv in JET of esm2 in bionemo2#428dorotat-nv wants to merge 24 commits into
dorotat-nv wants to merge 24 commits into
Conversation
Collaborator
|
Did we decide to do this with the CLI/argparse entrypoints? This is doable with the pydantic interface as well. |
pstjohn
reviewed
Nov 13, 2024
skothenhill-nv
approved these changes
Dec 2, 2024
pstjohn
approved these changes
Dec 2, 2024
…conv-jet-bionemo2
…conv-jet-bionemo2
…conv-jet-bionemo2
…conv-jet-bionemo2
Collaborator
Author
|
/build-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the first config of partial convergence training in JET for ESM2 model in BioNeMo 2
The JET pipeline can be submitted for this config by running
python jet/cli.py submit --root-dir ci/benchmarks/partial-conv/ --manifest-template-config-file <PATH_TO_CI_REPO>/jet/manifest_template_config.yamlwhere PATH_TO_CI_REPO is an absolute path to the CI repository storing JET CLI tools: https://gitlab-master.nvidia.com/clara-discovery/bionemo-github-ci/-/blob/master/jet/cli.py?ref_type=heads#L78
The PR it is still a draft. I need to adjust number of steps (due to 4h time limit and reducing nodes from 32 to 4). Also, I need to add test section.
In order to make the management of configs more robust, I will add a unit test in BioNeMo2 which checks if the training command can be executed.
TODO in the future: