Skip to content

Launchable notebooks in docs!#451

Merged
jstjohn merged 3 commits into
mainfrom
jstjohn/brev-launchable
Nov 19, 2024
Merged

Launchable notebooks in docs!#451
jstjohn merged 3 commits into
mainfrom
jstjohn/brev-launchable

Conversation

@jstjohn
Copy link
Copy Markdown
Collaborator

@jstjohn jstjohn commented Nov 19, 2024 •
edited
Loading

Changes:

  • Change default from PBSS to NGC for the load function.
  • Expose a new env variable to change the default for the load function so we can have one in tests and an easy way for an external user to change the behavior in ci locally.
  • Add new launchable link for the geneformer notebook.
Screenshot 2024-11-19 at 8 43 04 AM

@jstjohn
Copy link
Copy Markdown
Collaborator Author

jstjohn commented Nov 19, 2024

/build-ci

@jstjohn jstjohn marked this pull request as ready for review November 19, 2024 16:42
skothenhill-nv
skothenhill-nv reviewed Nov 19, 2024
View reviewed changes
Comment thread ci/scripts/run_pytest.sh
skothenhill-nv
skothenhill-nv approved these changes Nov 19, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@skothenhill-nv skothenhill-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pstjohn
pstjohn approved these changes Nov 19, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pstjohn pstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jstjohn jstjohn enabled auto-merge (squash) November 19, 2024 20:27
@jstjohn
Copy link
Copy Markdown
Collaborator Author

jstjohn commented Nov 19, 2024

/build-ci

@jstjohn jstjohn merged commit d35fe41 into main Nov 19, 2024
@jstjohn jstjohn deleted the jstjohn/brev-launchable branch November 19, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstjohn pstjohn pstjohn approved these changes

@farhadrgh farhadrgh farhadrgh approved these changes

@DejunL DejunL Awaiting requested review from DejunL

@dorotat-nv dorotat-nv Awaiting requested review from dorotat-nv

@guoqing-zhou guoqing-zhou Awaiting requested review from guoqing-zhou

+2 more reviewers

@malcolmgreaves malcolmgreaves malcolmgreaves approved these changes

@skothenhill-nv skothenhill-nv skothenhill-nv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jstjohn jstjohn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jstjohn @malcolmgreaves @pstjohn @farhadrgh @skothenhill-nv