Pstjohn/stop and go test non validation#476
Merged
pstjohn merged 9 commits intoDec 4, 2024
Merged
Conversation
c5deefd to
bbf2bd7
Compare
Collaborator
Author
|
/build-ci |
jstjohn
approved these changes
Dec 3, 2024
jstjohn
reviewed
Dec 3, 2024
sichu2023
reviewed
Dec 3, 2024
sichu2023
approved these changes
Dec 3, 2024
Contributor
sichu2023
left a comment
There was a problem hiding this comment.
Good to go. Only some comments to help me understand it better.
e8e4853 to
364659c
Compare
364659c to
117e00c
Compare
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly test that train inputs and outputs are consistent when we use PreemptionCallback to handle a training interrupt.
Currently it seems that doing this changes the validation step schedule, but otherwise training should be identical.
STOP OUTPUT:
RESUME OUTPUT:
CONTINUOUS OUTPUT: