change source for coverage report#495
Merged
Merged
Conversation
pstjohn
requested review from
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
jstjohn
approved these changes
Dec 3, 2024
Collaborator
Author
|
/build-ci |
trvachov
reviewed
Dec 3, 2024
Collaborator
trvachov
left a comment
trvachov
left a comment
There was a problem hiding this comment.
Peter could you just copy paste what a sample output looks like from this? Probably it works I just want to double check...
skothenhill-nv
approved these changes
Dec 3, 2024
Collaborator
Author
|
@trvachov Sure thing, this is from https://prod.blsm.nvidia.com/bionemo-external-bionemo-fw/job/test_pytest/966/pipeline-console/?selected-node=66 |
malcolmgreaves
approved these changes
Dec 3, 2024
Contributor
malcolmgreaves
left a comment
malcolmgreaves
left a comment
There was a problem hiding this comment.
LGTM. Suggest making the coverage report command clearer.
Signed-off-by: Peter St. John <peterc.stjohn@gmail.com>
Collaborator
Author
|
/build-ci |
Collaborator
|
Late to approve, but thanks for merging (my comments were NITs mostly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the
sourcefield for the coverage report, prints out which lines are missed.