[FEA][webdatamodule]: support webdataset invocable#501
Merged
Conversation
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
jstjohn
approved these changes
Dec 6, 2024
pstjohn
approved these changes
Dec 6, 2024
1699592 to
45c8088
Compare
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
keep getting CI failure in docker image building: which seems to result from: |
Collaborator
Author
|
/build-ci |
2 similar comments
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
45c8088 to
5654936
Compare
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
@pstjohn CI failed due to esm2 tests: |
Collaborator
Author
|
/build-ci |
5654936 to
53ca6e0
Compare
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
CI still fails with: |
These invocables are member functions of the webdataset or webloader class that return the the same instance their are invoked from. Previously webdatamodule does its own computation on the epoch length but now can rely on the user input directly using webdataset/webloader.with_epoch() due to this new additional feature
53ca6e0 to
d58edab
Compare
Collaborator
Author
|
/build-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The webdataset invocables are member functions of the webdataset or webloader class that return the the same instance their are invoked from. Previously webdatamodule does its own computation on the epoch length but now can rely on the user input directly using
webdataset/webloader.with_epoch()due to this new additional featureDetails
Describe your changes. You can be more detailed and descriptive here. If it is a code change, Be sure to answer:
(see the summary above)
These invocables are parts of the webdataset usage and we have been using them in diffdock to set up the epoch length and other properties of the dataset and dataloader objects.
(see the updated README.md regarding the
invoke_wdsandinvoke_wldarguments on webdatamodule)Usage
How does a user interact with the changed code?
(see the updated README.md regarding the
invoke_wdsandinvoke_wldarguments on webdatamodule)Testing
Tests for these changes can be run via:
Most of the changes to files with extensions
*.py,*.yaml,*.yml,Dockerfile*orrequirements.txtDO REQUIRE bothpytest-andjet-CI stages.SKIP_CIlabel to your PR?PYTEST_NOT_REQUIREDlabel to your PR?JET_NOT_REQUIREDlabel to your PR?