added NeMoLogger unit tests#511
Merged
Merged
Conversation
Collaborator
Author
|
\build-ci |
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
dorotat-nv
commented
Dec 9, 2024
Collaborator
Author
|
/build-ci |
skothenhill-nv
approved these changes
Dec 9, 2024
Collaborator
|
/build-ci |
pstjohn
approved these changes
Dec 9, 2024
Collaborator
Author
|
/build-ci |
dorotat-nv
commented
Dec 9, 2024
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
Collaborator
Author
|
/build-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding hotfix and unit tests uncovering issue with WandbLogger in https://nvidia.slack.com/archives/C074Z808N05/p1733418209959769
DETAILS
An interesting observation: this genuinely appears to be a wandb bug, since it can only be captured once it’s converted into a Lightning hook during training. Only one out of 4 new unit tests fails when probably all of them should
The error is only uncovered only after
NeMoLoggersetup as n https://github.com/NVIDIA/NeMo/blob/bb895bc4b28ba99d707cb907c4496297a2a7b533/nemo/collections/llm/api.py#L852C22-L856C6and after
plt.Trainersetup at the start of the training inhttps://github.com/Lightning-AI/pytorch-lightning/blob/de7c28ae865b5c9fd3ff21debebb994605f7f420/src/lightning/pytorch/trainer/trainer.py#L944
which is executed in
https://github.com/Lightning-AI/pytorch-lightning/blob/caa9e1e59436913e365bf52eeb2b07e3bf67efac/src/lightning/pytorch/trainer/call.py#L94C1-L97C34
TESTING ON BROKEN MAIN BRANCH