Remove outdated note on very large datasets in MultiEpochDataset#521
Merged
pstjohn merged 1 commit intoJan 13, 2025
Merged
Conversation
pstjohn
requested review from
dorotat-nv,
jstjohn and
malcolmgreaves
as code owners
jstjohn
approved these changes
Dec 11, 2024
dorotat-nv
approved these changes
Jan 13, 2025
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
force-pushed
the
pstjohn/remove-large-dataset-note
branch
from
bc895f9 to
f19619a
Compare
Collaborator
Author
|
/build-ci |
sichu2023
pushed a commit
that referenced
this pull request
Jan 17, 2025
Thanks to Savitha for pointing out this bit of the docs that's no longer relevant. We have a new algorithm here that makes the MultiEpochDataset also O(1) Signed-off-by: Peter St. John <pstjohn@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Savitha for pointing out this bit of the docs that's no longer relevant. We have a new algorithm here that makes the MultiEpochDataset also O(1)