xFail known bad tests on H100 and fix CVEs#549
Merged
Conversation
Known issue on H100 (and GH200) with loading checkpoints. Also fixing CVE in ARM container
gagank1
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
pstjohn and
skothenhill-nv
as code owners
Contributor
Author
|
/build-ci |
cspades
approved these changes
Dec 19, 2024
pstjohn
approved these changes
Dec 19, 2024
jstjohn
approved these changes
Dec 19, 2024
Collaborator
jstjohn
left a comment
jstjohn
left a comment
There was a problem hiding this comment.
Approve but please make the test only xfail when not on H100 (or see my suggestion about also testing for cudnn version since I think it should work again with newer cuDNN, eg when we upgrade the base pytorch container to 24.10-py3.)
skothenhill-nv
approved these changes
Dec 19, 2024
Contributor
Author
|
/build-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.