Skip to content

fix image links in esm2 model card#584

Merged
pstjohn merged 7 commits into
NVIDIA-BioNeMo:mainfrom
pstjohn:pstjohn/fix-image-links-esm2
Jan 15, 2025
Merged

fix image links in esm2 model card#584
pstjohn merged 7 commits into
NVIDIA-BioNeMo:mainfrom
pstjohn:pstjohn/fix-image-links-esm2

Conversation

@pstjohn
Copy link
Copy Markdown
Collaborator

@pstjohn pstjohn commented Jan 8, 2025

Description

Updates broken image links in ESM-2 model card

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe):

CI Pipeline Configuration

Configure CI behavior by checking relevant boxes below. This will automatically apply labels.

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Usage

TODO: Add code snippet

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

@pstjohn pstjohn added the SKIP_CI label Jan 9, 2025
@pstjohn pstjohn added this to the 25.01 Release milestone Jan 9, 2025
@dorotat-nv
Copy link
Copy Markdown
Collaborator

/build-ci

@sichu2023 sichu2023 self-requested a review January 9, 2025 18:00
Copy link
Copy Markdown
Contributor

@sichu2023 sichu2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/docs/models/ESM-2/pre-training.md Outdated
@pstjohn pstjohn force-pushed the pstjohn/fix-image-links-esm2 branch from 0c66c63 to 42c7f7e Compare January 14, 2025 16:16
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@pstjohn pstjohn force-pushed the pstjohn/fix-image-links-esm2 branch from 6eb159e to 58dc705 Compare January 15, 2025 18:55
Comment thread docs/docs/models/ESM-2/pre-training.md
@pstjohn pstjohn added this pull request to the merge queue Jan 15, 2025
Merged via the queue into NVIDIA-BioNeMo:main with commit 448f353 Jan 15, 2025
@pstjohn pstjohn deleted the pstjohn/fix-image-links-esm2 branch January 15, 2025 20:27
sichu2023 pushed a commit that referenced this pull request Jan 17, 2025
### Description
Updates broken image links in ESM-2 model card

### Type of changes
<!-- Mark the relevant option with an [x] -->

- [ ]  Bug fix (non-breaking change which fixes an issue)
- [ ]  New feature (non-breaking change which adds functionality)
- [ ]  Refactor
- [x]  Documentation update
- [ ]  Other (please describe):

### CI Pipeline Configuration
Configure CI behavior by checking relevant boxes below. This will
automatically apply labels.

- [x]
[SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci)
- Skip all continuous integration tests
- [ ]
[INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests)
- Execute notebook validation tests in pytest

> [!NOTE]
> By default, the notebooks validation tests are skipped unless
explicitly enabled.

### Usage
<!--- How does a user interact with the changed code -->
```python
TODO: Add code snippet
```

### Pre-submit Checklist
<!--- Ensure all items are completed before submitting -->

 - [ ] I have tested these changes locally
 - [ ] I have updated the documentation accordingly
 - [ ] I have added/updated tests as needed
 - [ ] All existing tests pass successfully

---------

Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants