fix perplexity logging#622
Merged
Merged
Conversation
8f13212 to
6800366
Compare
6800366 to
aad63ec
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 86.62% 86.58% -0.05%
==========================================
Files 116 116
Lines 6961 6931 -30
==========================================
- Hits 6030 6001 -29
+ Misses 931 930 -1
🚀 New features to boost your workflow:
|
ea78996 to
0bd0330
Compare
farhadrgh
approved these changes
Jan 21, 2025
Collaborator
farhadrgh
left a comment
There was a problem hiding this comment.
Left some minor comments, LGTM
25286db to
0c97e81
Compare
skothenhill-nv
approved these changes
Jan 21, 2025
Collaborator
skothenhill-nv
left a comment
There was a problem hiding this comment.
looks like there are some major diffs that seem unrelated to the change, is there a leaky merge happening here?
Signed-off-by: sichu <sichu@nvidia.com>
Signed-off-by: sichu <sichu@nvidia.com>
Signed-off-by: sichu <sichu@nvidia.com>
Signed-off-by: sichu <sichu@nvidia.com>
Signed-off-by: sichu <sichu@nvidia.com>
Signed-off-by: sichu <sichu@nvidia.com>
Signed-off-by: sichu <sichu@nvidia.com>
0c97e81 to
f6b893a
Compare
Contributor
Author
Intentionally changes to drop forward output for logging since we are moving to torchmetric now. |
jstjohn
approved these changes
Jan 21, 2025
polinabinder1
pushed a commit
that referenced
this pull request
Jan 22, 2025
Replace callback method in logging perplexity with torchmetrics.   Loss curve is shifted by a constant when TP=2 but gradient is not affected and the perplexity value match with the loss curve without TP. This is a previously unidentified problem and will be resolved by another PR.    --------- Signed-off-by: sichu <sichu@nvidia.com> Signed-off-by: Polina Binder <pbinder@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace callback method in logging perplexity with torchmetrics.


Loss curve is shifted by a constant when TP=2 but gradient is not affected and the perplexity value match with the loss curve without TP. This is a previously unidentified problem and will be resolved by another PR.


