hotfix for some failing python tests due to NGC files being moved around#626
Merged
Merged
Conversation
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
requested review from
DejunL,
dorotat-nv,
farhadrgh,
guoqing-zhou,
jstjohn,
malcolmgreaves,
skothenhill-nv and
trvachov
as code owners
dorotat-nv
approved these changes
Jan 21, 2025
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
jstjohn
approved these changes
Jan 21, 2025
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 116 116
Lines 6961 6961
=======================================
Hits 6030 6030
Misses 931 931 ☔ View full report in Codecov by Sentry. |
polinabinder1
pushed a commit
that referenced
this pull request
Jan 22, 2025
…und (#626) Fixes failing tests due to NGC resource files being moved around, and renames some of the ESM-2 resources to better delineate checkpoints we trained on our internal data from those converted from the original ESM-2 model weights. --------- Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Polina Binder <pbinder@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failing tests due to NGC resource files being moved around, and renames some of the ESM-2 resources to better delineate checkpoints we trained on our internal data from those converted from the original ESM-2 model weights.