catch ngc api key validation errors and default to not using an api key#635
Merged
pstjohn merged 2 commits intoJan 22, 2025
Merged
Conversation
…ey for guest access Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
requested review from
DejunL,
dorotat-nv,
farhadrgh,
guoqing-zhou,
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
trvachov
approved these changes
Jan 22, 2025
Collaborator
trvachov
left a comment
trvachov
left a comment
There was a problem hiding this comment.
awesome peter thanks for being proactive in fixing these things.
farhadrgh
approved these changes
Jan 22, 2025
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
=======================================
Coverage 86.59% 86.60%
=======================================
Files 116 116
Lines 6936 6948 +12
=======================================
+ Hits 6006 6017 +11
- Misses 930 931 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix issues like https://nvbugspro.nvidia.com/bug/5063178, where the SLURM environment picks up a stray and incorrect NGC api key.