Skip to content

remove PerplexityCallback in pydantic api#636

Merged
sichu2023 merged 1 commit into
mainfrom
sichu/fix-pydantic-ppl
Jan 22, 2025
Merged

remove PerplexityCallback in pydantic api#636
sichu2023 merged 1 commit into
mainfrom
sichu/fix-pydantic-ppl

Conversation

@sichu2023
Copy link
Copy Markdown
Contributor

@sichu2023 sichu2023 commented Jan 22, 2025

Description

Fix CI by dropping PerplexityCallback in pydantic api

Type of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)

Usage

pytest sub-packages/bionemo-esm2/tests/bionemo/esm2/scripts/test_pydantic_train.py::test_pretrain_pydantic_cli

Related to e553389

@sichu2023 sichu2023 added the bug Something isn't working label Jan 22, 2025
@sichu2023 sichu2023 self-assigned this Jan 22, 2025
Signed-off-by: sichu <sichu@nvidia.com>
@sichu2023 sichu2023 force-pushed the sichu/fix-pydantic-ppl branch from 4cc6b6a to c8be9f7 Compare January 22, 2025 18:33
@sichu2023 sichu2023 enabled auto-merge January 22, 2025 18:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.59%. Comparing base (a2fd916) to head (c8be9f7).
⚠️ Report is 562 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files         116      116           
  Lines        6937     6937           
=======================================
  Hits         6007     6007           
  Misses        930      930           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sichu2023 sichu2023 added this pull request to the merge queue Jan 22, 2025
auto-merge was automatically disabled January 22, 2025 21:08

Pull Request is not mergeable

Merged via the queue into main with commit 4ae9f09 Jan 22, 2025
@sichu2023 sichu2023 deleted the sichu/fix-pydantic-ppl branch January 22, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants