add timing callback#657
Merged
Merged
Conversation
sichu2023
requested review from
farhadrgh,
jomitchellnv,
jstjohn,
pstjohn and
skothenhill-nv
as code owners
Contributor
Author
|
|
Signed-off-by: sichu <sichu@nvidia.com>
sichu2023
force-pushed
the
sichu/timeing_callback
branch
from
38bff8d to
4f357f1
Compare
pstjohn
approved these changes
Jan 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 118 118
Lines 7058 7059 +1
=======================================
+ Hits 6123 6124 +1
Misses 935 935
🚀 New features to boost your workflow:
|
Collaborator
|
Just a heads up -- you probably didn't need slow and notebook tests here. Those will get run during the merge queue check anyways. |
sichu2023
added a commit
that referenced
this pull request
Feb 10, 2025
### Description Add timing callback to log train step time in second - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): Signed-off-by: sichu <sichu@nvidia.com>
sichu2023
added a commit
that referenced
this pull request
Feb 10, 2025
### Description Add timing callback to log train step time in second - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): Signed-off-by: sichu <sichu@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add timing callback to log train step time in second