add back transformer engine install#658
Merged
Merged
Conversation
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
ohadmo and
trvachov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 118 118
Lines 7059 7059
=======================================
Hits 6124 6124
Misses 935 935 ☔ View full report in Codecov by Sentry. |
dorotat-nv
approved these changes
Jan 28, 2025
jstjohn
reviewed
Jan 28, 2025
jstjohn
approved these changes
Jan 28, 2025
auto-merge was automatically disabled
January 28, 2025 21:57
Pull request was converted to draft
Signed-off-by: Peter St. John <peterc.stjohn@gmail.com>
Signed-off-by: Peter St. John <peterc.stjohn@gmail.com>
sichu2023
pushed a commit
that referenced
this pull request
Feb 10, 2025
Adds back the custom transformer engine install to avoid the import error on python debugging. https://nvidia.slack.com/archives/C074Z808N05/p1737753519355939 --------- Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Peter St. John <peterc.stjohn@gmail.com> Signed-off-by: sichu <sichu@nvidia.com>
sichu2023
pushed a commit
that referenced
this pull request
Feb 10, 2025
Adds back the custom transformer engine install to avoid the import error on python debugging. https://nvidia.slack.com/archives/C074Z808N05/p1737753519355939 --------- Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Peter St. John <peterc.stjohn@gmail.com> Signed-off-by: sichu <sichu@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds back the custom transformer engine install to avoid the import error on python debugging. https://nvidia.slack.com/archives/C074Z808N05/p1737753519355939