Updated file paths for images in SCDL README#758
Merged
Conversation
polinabinder1
requested review from
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
polinabinder1
added
documentation
jstjohn
reviewed
Mar 14, 2025
jstjohn
approved these changes
Mar 14, 2025
Collaborator
jstjohn
left a comment
jstjohn
left a comment
There was a problem hiding this comment.
Ok with this for now, See discussion in slack thread about the need for a better long term solution: https://nvidia.slack.com/archives/C074Z808N05/p1741975424499369
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 84.14% 84.13% -0.02%
==========================================
Files 128 128
Lines 8036 8036
==========================================
- Hits 6762 6761 -1
- Misses 1274 1275 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
…r correct rendering Signed-off-by: Jared Wilber <jwilber@nvidia.com>
jwilber
requested review from
dorotat-nv,
jwilber,
pstjohn and
trvachov
as code owners
jwilber
approved these changes
Mar 14, 2025
Collaborator
jwilber
left a comment
jwilber
left a comment
There was a problem hiding this comment.
- updated mkdocs render logic by adding get_subpackage_assets function to correctly copy assets over using mkdocs_gen_files
- renamed images/ dir to assets/
- udpated reademe so that the
tags were replaced with markdown image syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.