parallelize test stages in GitHub CI#768
Conversation
e812faf to
cd24fe2
Compare
Signed-off-by: dorotat <dorotat@nvidia.com>
Signed-off-by: dorotat <dorotat@nvidia.com>
d7b6fe4 to
1c71aaa
Compare
|
/ok to test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 129 129
Lines 8116 8116
=======================================
Hits 6784 6784
Misses 1332 1332 ☔ View full report in Codecov by Sentry. |
|
/ok to test |
trvachov
left a comment
There was a problem hiding this comment.
LGTM but @dorotat-nv can you please draw out what kinds of tests we have in CI now (slow/notslow, notebooks), and when each one runs? in NVKS? In Jenkins? etc? Just a single slide.
@trvachov , added charts with current workflow in CI and a workflow after parallelization |
Signed-off-by: dorotat <dorotat@nvidia.com>
|
/ok to test |
Signed-off-by: dorotat <dorotat@nvidia.com>
|
/ok to test |
|
/ok to test |
e666114 to
0f49c39
Compare
|
/ok to test |
Description
Parallelising testing stages in GitHub CI to run in the same time to speedup pipeline
Added verify-tests-status as a final job that checks the tests status and if success or skipped, then success
Checked that everything works
test status job collects test status so we will be able to add it as a check for pipeline success
https://github.com/NVIDIA/bionemo-framework/actions/runs/13976419866/job/39135551206
https://github.com/NVIDIA/bionemo-framework/actions/runs/13991973092/job/39177843004?pr=768
EDIT:
Removed flag
INCLUDE_NOTEBOOKS_TESTSsince some of the notebooks do not pass CI pipeline, seefailed job logs.
Fix is being merged in #743
Current workflow in CI
** duration: 18 min, see log
**minimum: image_squashing_time + duration_L0 ~ 50mins,
**maximum: image_squashing_time + duration_L0, + duration_L1 + duration_docs ~ 2h
Proposed parallelization:
duration: 18 min, see log
**minimum: image_squashing_time + duration_L0 ~ 50mins,
**maximum: image_squashing_time + max(duration_L0, duration_L1, duration_docs) ~1h10mins
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Usage
Pre-submit Checklist