Dockerfile improvements for ARM#777
Merged
Merged
Conversation
trvachov
requested review from
DejunL,
cspades,
dorotat-nv,
farhadrgh,
guoqing-zhou,
jomitchellnv,
jstjohn,
jwilber,
malcolmgreaves,
nvdreidenbach,
ohadmo,
pstjohn,
sichu2023,
skothenhill-nv,
youhanl-nvidia and
zcao0420
as code owners
Collaborator
Author
Collaborator
Author
|
/ok to test |
pstjohn
approved these changes
Mar 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 84.30% 84.30%
=======================================
Files 137 137
Lines 8635 8635
=======================================
Hits 7280 7280
Misses 1355 1355 ☔ View full report in Codecov by Sentry. |
trvachov
force-pushed
the
trvachov/docker-update
branch
9 times, most recently
from
50ecf81 to
5a3e775
Compare
Collaborator
Author
|
Confirmed passing GH200 tests: Pipeline 1894 |
Collaborator
Author
|
/ok to test |
jomitchellnv
reviewed
Apr 1, 2025
jomitchellnv
reviewed
Apr 1, 2025
jomitchellnv
approved these changes
Apr 1, 2025
Collaborator
jomitchellnv
left a comment
jomitchellnv
left a comment
There was a problem hiding this comment.
Approved with small nits
trvachov
force-pushed
the
trvachov/docker-update
branch
2 times, most recently
from
62ba148 to
23cfa51
Compare
Collaborator
Author
|
/ok to test |
trvachov
force-pushed
the
trvachov/docker-update
branch
from
23cfa51 to
73cc30f
Compare
Collaborator
Author
|
/ok to test |
Signed-off-by: Timur Rvachov <trvachov@nvidia.com>
trvachov
force-pushed
the
trvachov/docker-update
branch
from
73cc30f to
2aea7ee
Compare
Collaborator
Author
|
/ok to test |
Collaborator
Author
|
@pstjohn @jomitchellnv I addressed and resolved the comments -- hope that was ok! |
cspades
pushed a commit
that referenced
this pull request
May 4, 2025
Updates network pull (AWS cli, NGC) deps. ### Description This tries to keep both x86 and ARM build in a single Dockerfile, so the diff is easy to understand. Some dependencies (ngc/aws) had to be updates to get this to work on ARM. ### Type of changes <!-- Mark the relevant option with an [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest - [INCLUDE_SLOW_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_slow_tests) - Execute tests labelled as slow in pytest for extensive testing > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. * If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) * If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [x] I have tested these changes locally - [x] I have updated the documentation accordingly - [x] I have added/updated tests as needed - [ ] All existing tests pass successfully Signed-off-by: Timur Rvachov <trvachov@nvidia.com> Signed-off-by: Cory Ye <cye@nvidia.com>
farhadrgh
pushed a commit
that referenced
this pull request
May 5, 2025
Updates network pull (AWS cli, NGC) deps. ### Description This tries to keep both x86 and ARM build in a single Dockerfile, so the diff is easy to understand. Some dependencies (ngc/aws) had to be updates to get this to work on ARM. ### Type of changes <!-- Mark the relevant option with an [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest - [INCLUDE_SLOW_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_slow_tests) - Execute tests labelled as slow in pytest for extensive testing > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. * If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) * If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [x] I have tested these changes locally - [x] I have updated the documentation accordingly - [x] I have added/updated tests as needed - [ ] All existing tests pass successfully Signed-off-by: Timur Rvachov <trvachov@nvidia.com> Signed-off-by: Farhad Ramezanghorbani <farhadr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates network pull (AWS cli, NGC) deps.
Description
This tries to keep both x86 and ARM build in a single Dockerfile, so the diff is easy to understand.
Some dependencies (ngc/aws) had to be updates to get this to work on ARM.
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Pre-submit Checklist