Pbinder/geneformer partial conv#802
Merged
Merged
Conversation
Signed-off-by: Polina Binder <pbinder@nvidia.com>
Signed-off-by: Polina Binder <pbinder@nvidia.com>
Signed-off-by: Polina Binder <pbinder@nvidia.com>
Signed-off-by: Polina Binder <pbinder@nvidia.com>
Signed-off-by: Polina Binder <pbinder@nvidia.com>
polinabinder1
requested review from
dorotat-nv,
malcolmgreaves and
pstjohn
as code owners
dorotat-nv
reviewed
Apr 4, 2025
Signed-off-by: Polina Binder <pbinder@nvidia.com>
dorotat-nv
approved these changes
Apr 8, 2025
polinabinder1
requested review from
cspades,
jstjohn,
jwilber,
sichu2023,
skothenhill-nv and
trvachov
as code owners
Signed-off-by: polinabinder1 <pbinder@nvidia.com>
Signed-off-by: polinabinder1 <pbinder@nvidia.com>
Signed-off-by: Polina Binder <pbinder@nvidia.com>
Collaborator
Author
|
/ok to test f19c2ae |
Collaborator
Author
|
/ok to test f19c2ae |
1 similar comment
Collaborator
Author
|
/ok to test f19c2ae |
Collaborator
Author
|
/ok to test 4a0837c |
Collaborator
Author
|
/ok to test 5d21cde |
Collaborator
Author
|
/ok to test b8a330f |
Collaborator
Author
|
/ok to test f19c2ae |
Collaborator
|
/ok to test f19c2ae |
Collaborator
|
/ok to test |
skothenhill-nv
approved these changes
Apr 10, 2025
auto-merge was automatically disabled
April 10, 2025 20:53
Pull Request is not mergeable
cspades
pushed a commit
that referenced
this pull request
May 4, 2025
Adding partial conversion test for geneformer. So far, this is missing FLOPsMeasurementCallback and is waiting on a NeMo MR for this: NVIDIA-NeMo/NeMo#12774 --------- Signed-off-by: Polina Binder <pbinder@nvidia.com> Signed-off-by: polinabinder1 <pbinder@nvidia.com> Signed-off-by: Cory Ye <cye@nvidia.com>
farhadrgh
pushed a commit
that referenced
this pull request
May 5, 2025
Adding partial conversion test for geneformer. So far, this is missing FLOPsMeasurementCallback and is waiting on a NeMo MR for this: NVIDIA-NeMo/NeMo#12774 --------- Signed-off-by: Polina Binder <pbinder@nvidia.com> Signed-off-by: polinabinder1 <pbinder@nvidia.com> Signed-off-by: Farhad Ramezanghorbani <farhadr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding partial conversion test for geneformer. So far, this is missing FLOPsMeasurementCallback and is waiting on a NeMo MR for this: NVIDIA-NeMo/NeMo#12774