Remove import guard in bionemo-llm#804
Merged
Merged
Conversation
pstjohn
requested review from
DejunL,
dorotat-nv,
farhadrgh,
guoqing-zhou,
jstjohn,
malcolmgreaves,
ohadmo,
skothenhill-nv and
trvachov
as code owners
cspades
reviewed
Apr 7, 2025
cspades
approved these changes
Apr 7, 2025
dorotat-nv
approved these changes
Apr 9, 2025
Collaborator
dorotat-nv
left a comment
dorotat-nv
left a comment
There was a problem hiding this comment.
Have seem those changes in #809
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
pstjohn
force-pushed
the
pstjohn/remove-apex-import
branch
from
8f6a4f1 to
1d6a0ff
Compare
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
force-pushed
the
pstjohn/remove-apex-import
branch
from
1d6a0ff to
9198762
Compare
pstjohn
changed the title
cspades
pushed a commit
that referenced
this pull request
May 4, 2025
We don't need a backup apex import in bionemo-llm's datamodule, since we can be sure that import exists in our megatron version Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Cory Ye <cye@nvidia.com>
farhadrgh
pushed a commit
that referenced
this pull request
May 5, 2025
We don't need a backup apex import in bionemo-llm's datamodule, since we can be sure that import exists in our megatron version Signed-off-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: Farhad Ramezanghorbani <farhadr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need a backup apex import in bionemo-llm's datamodule, since we can be sure that import exists in our megatron version