scdl neighbor update#843
Conversation
|
On a high level - test cases! |
|
/ok to test c6fa91e |
skothenhill-nv
left a comment
There was a problem hiding this comment.
Left mostly style and documentation related comments. One thing I noticed is from a top down reading, its not clear what the expected behavior is when neighbor data is requested but doesnt exist. I saw a few methods where an exception is raised, and others return a boolean or maybe throw a warning. If you feel like you have the control flow in a good place for incomplete neighbor data then no worries- but if not it might be worth taking another pass. Approved for now, I trust youll merge when comments are addressed.
polinabinder1
left a comment
There was a problem hiding this comment.
Remove the 3rdParty changes - they should be the same as in main.
@polinabinder1 I'm not sure why, but I realize at some point when i initialized the submodules they showed up as changes to be committed under 'git status' and I did. I just reverted that commit. |
|
/ok to test c562990 |
c562990 to
7a33849
Compare
Signed-off-by: Camir Ricketts <camirr@nvidia.com>
50d1981 to
ac9cf78
Compare
Signed-off-by: Camir Ricketts <camirr@nvidia.com>
|
/ok to test 6943412 |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
+ Coverage 84.18% 84.24% +0.06%
==========================================
Files 144 144
Lines 9229 9394 +165
==========================================
+ Hits 7769 7914 +145
- Misses 1460 1480 +20
|
Signed-off-by: Camir Ricketts <camirr@nvidia.com>
Signed-off-by: Camir Ricketts <camirr@nvidia.com>
|
/ok to test 402bc66 |
Description
This PR introduces comprehensive neighbor sampling functionality to the Single Cell Data Loader (SCDL), enabling efficient retrieval of cell neighbors for graph-based machine learning workflows and spatial analysis tasks.
Core Functionality
Public API Methods
Internal Implementation Methods
File Structure
-- neighbor_indices.npy: Contains neighbor cell indices in CSR format
-- neighbor_indptr.npy: Index pointers for CSR sparse matrix structure
-- neighbor_values.npy: Weights/values associated with neighbor relationships
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Usage
Pre-submit Checklist