Update evo2 ModelCheckpoint args#935
Merged
Merged
Conversation
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
jwilber
requested review from
cspades,
dorotat-nv,
jomitchellnv,
jstjohn,
malcolmgreaves,
pstjohn,
sichu2023,
skothenhill-nv,
trvachov and
tshimko-nv
as code owners
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
jwilber
force-pushed
the
jwilber/evo2-add-save-top-k-arg
branch
from
74eb26f to
96b6bc4
Compare
malcolmgreaves
approved these changes
Jun 9, 2025
farhadrgh
approved these changes
Jun 9, 2025
Collaborator
Author
|
/ok to test 96b6bc4 |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
- Coverage 84.21% 84.17% -0.04%
==========================================
Files 143 143
Lines 9061 9064 +3
==========================================
- Hits 7631 7630 -1
- Misses 1430 1434 +4
|
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
Collaborator
Author
|
/ok to test 9b64b79 |
jwilber
changed the title
camirr-nv
pushed a commit
that referenced
this pull request
Jun 26, 2025
### Description Adds new arguments to control `ModelCheckpoint`. ### Type of changes <!-- Mark the relevant option with an [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Refactor - [x] Documentation update - [ ] Other (please describe): ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [x] I have tested these changes locally - [x] I have updated the documentation accordingly - [x] I have added/updated tests as needed - [x] All existing tests pass successfully --------- Signed-off-by: Jared Wilber <jwilber@nvidia.com> Signed-off-by: Ubuntu <camirr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new arguments to control
ModelCheckpoint.Type of changes
Pre-submit Checklist