Reset parameters for the ESM-2 contact head on HF export#983
Merged
pstjohn merged 1 commit intoJul 24, 2025
Conversation
Previously this weight was not initialized, and would be the result of whatever torch.empty() assigned to these values. If we want to use this layer in downstream tasks, we should at least randomly init these weights to reasonable values. Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
requested review from
farhadrgh,
jomitchellnv,
jstjohn,
sichu2023 and
skothenhill-nv
as code owners
jstjohn
reviewed
Jul 18, 2025
jstjohn
approved these changes
Jul 18, 2025
edawson
pushed a commit
that referenced
this pull request
Jul 28, 2025
Previously this weight was not initialized, and would be the result of whatever torch.empty() assigned to these values. If we want to use this layer in downstream tasks, we should at least randomly init these weights to reasonable values. Signed-off-by: Peter St. John <pstjohn@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this weight was not initialized, and would be the result of whatever torch.empty() assigned to these values. If we want to use this layer in downstream tasks, we should at least randomly init these weights to reasonable values.