Addressing new inference updates in mcore#706
Merged
Conversation
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
oyilmaz-nvidia
requested review from
athitten,
meatybobby and
pthombre
as code owners
Contributor
Author
|
/ok to test 7143ebf |
athitten
approved these changes
Jun 12, 2026
athitten
left a comment
athitten
left a comment
Contributor
There was a problem hiding this comment.
Thank you @oyilmaz-nvidia , LGTM
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Contributor
Author
|
/ok to test 8704af9 |
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Contributor
Author
|
/ok to test e67b52c |
…xt>=0.6.0 megatron-core raises AssertionError (not ImportError) at import time when nvidia-resiliency-ext<0.6.0 is installed. Adding AssertionError to the except clause in deploy_ray.py lets the existing HAVE_RAY=False fallback handle this gracefully, fixing test_deploy_ray.py collection errors in CI. Also bumps the override pin from >=0.3.0,<=0.6.0 to >=0.6.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Contributor
Author
|
/ok to test 88c700e |
Co-authored-by: nemo-autobot-origin[bot] <297562586+nemo-autobot-origin[bot]@users.noreply.github.com>
Contributor
|
/ok to test 212dc9a |
chtruong814
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.