chore(docker): AUT-1344 uninstall pyelftools to address dependency/license issues - #736
Merged
balasaajay merged 1 commit intoAug 5, 2026
Conversation
Remove pyelftools from the container image after dependency installation, matching the approach in NVIDIA-NeMo/Megatron-Bridge#5330. Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
|
/ok to test ab32e7f |
balasaajay
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
pyelftoolsis pulled in as a transitive dependency but is not needed at runtime. It was identified as causing dependency/license issues in the container image. This mirrors the fix in NVIDIA-NeMo/Megatron-Bridge#5330.What changed
pip uninstall -y pyelftoolsafter dependency installation in the pip path ofdocker/common/install.sh.uv pip uninstall pyelftools(without-y, since uv 0.7.2 does not support that flag) in the uv path.Details
flowchart LR A[install.sh] --> B{USE_UV?} B -->|yes| C[uv sync + uv pip install] C --> D[uv pip uninstall pyelftools] B -->|no| E[pip install] E --> F[pip uninstall -y pyelftools]docker/common/install.sh— addedpyelftoolsuninstall in both the uv-based and pip-based install paths, right after dependencies are installed. The uv path omits-ybecause uv 0.7.2'spip uninstalldoes not accept that flag.Tested
bash -n docker/common/install.sh— shell syntax validated (exit 0). Verifieduv pip uninstall pyelftools(no-y) andpip uninstall -y pyelftoolsare the correct commands for their respective tools.